Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filebeat] Add RabbitMQ filebeat module #12032

Merged
merged 16 commits into from
May 16, 2019
Merged

[Filebeat] Add RabbitMQ filebeat module #12032

merged 16 commits into from
May 16, 2019
+764 −1

Commits on May 16, 2019

  1. Add a RabbitMQ filebeat. Accepts single and multiline messages. 

    "works on my machine" but lots of TODOs remain

Took a shot at ECS. Tested with

```
 ~/go/src/github.com/elastic/beats/x-pack/filebeat [master @ 092a3f5] ✓ ‣ MODULES_PATH=./module GENERATE=1 INTEGRATION_TESTS=1 TESTING_FILEBEAT_MODULES=rabbitmq nosetests tests/system/test_xpack_modules.py -v
test_fileset_file_0_rabbitmq (test_xpack_modules.XPackTest) ... ok

----------------------------------------------------------------------
Ran 1 test in 3.320s

OK
```
    John Schulz committed May 16, 2019
    Configuration menu
    Copy the full SHA
    db189eb View commit details
    Browse the repository at this point in the history

  2. Add alias from ECS fields to rabbitmq.log.* 

    Update fields and docs.
    John Schulz committed May 16, 2019
    Configuration menu
    Copy the full SHA
    896545b View commit details
    Browse the repository at this point in the history

  3. Run mage fmt update as requested by CI

    John Schulz committed May 16, 2019
    Configuration menu
    Copy the full SHA
    4499b09 View commit details
    Browse the repository at this point in the history

  4. Update x-pack/filebeat/module/rabbitmq/_meta/config.yml 

    Co-Authored-By: jfsiii <github.com@jfsiii.org>
    @ruflin @jfsiii
    2 people authored and John Schulz committed May 16, 2019
    Configuration menu
    Copy the full SHA
    243498d View commit details
    Browse the repository at this point in the history

  5. Update x-pack/filebeat/module/rabbitmq/_meta/config.yml 

    Co-Authored-By: jfsiii <github.com@jfsiii.org>
    @ruflin @jfsiii
    2 people authored and John Schulz committed May 16, 2019
    Configuration menu
    Copy the full SHA
    69a6353 View commit details
    Browse the repository at this point in the history

  6. Address feedback 

     * add missing test.log-expected.json
 * remove aliases
 * re-run `mage update` and `mage fmt update`
    John Schulz committed May 16, 2019
    Configuration menu
    Copy the full SHA
    89ed898 View commit details
    Browse the repository at this point in the history

  7. Add changelog.next entry in Added > Filebeat

    John Schulz committed May 16, 2019
    Configuration menu
    Copy the full SHA
    0a9bebb View commit details
    Browse the repository at this point in the history

  8. Add config examples. Format links correctly.

    John Schulz committed May 16, 2019
    Configuration menu
    Copy the full SHA
    30e4571 View commit details
    Browse the repository at this point in the history

  9. Follow convention for adding timezone via var.convert_timezone

    John Schulz committed May 16, 2019
    Configuration menu
    Copy the full SHA
    63fcd83 View commit details
    Browse the repository at this point in the history

  10. If present, use RABBITMQ_LOGS env variable for var.paths setting 

    Use format detailed in https://www.elastic.co/guide/en/beats/filebeat/master/using-environ-vars.html
    John Schulz committed May 16, 2019
    Configuration menu
    Copy the full SHA
    7dc222e View commit details
    Browse the repository at this point in the history

  11. No dashboard for now.

    John Schulz committed May 16, 2019
    Configuration menu
    Copy the full SHA
    419c7dc View commit details
    Browse the repository at this point in the history

  12. Use YML for pipeline config 

    Unrelated whitespace change
    John Schulz committed May 16, 2019
    Configuration menu
    Copy the full SHA
    c762cc9 View commit details
    Browse the repository at this point in the history

  13. Whitespace changes missed in 2fbbe2eb

    John Schulz committed May 16, 2019
    Configuration menu
    Copy the full SHA
    f5d901f View commit details
    Browse the repository at this point in the history

  14. PR feedback. Remove module.yml & note about MacOS

    John Schulz committed May 16, 2019
    Configuration menu
    Copy the full SHA
    734359a View commit details
    Browse the repository at this point in the history

  15. TZ default on for this module. Update docs & tests

    John Schulz committed May 16, 2019
    Configuration menu
    Copy the full SHA
    cb8e632 View commit details
    Browse the repository at this point in the history

  16. Be explicit when creating @timestamp field. 

    This is also consistent with other filebeats.
    John Schulz committed May 16, 2019
    Configuration menu
    Copy the full SHA
    013cf0b View commit details
    Browse the repository at this point in the history