[Auditbeat] System module: Shorten entity ids #11405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwurm
added
review
needs_backport
|
Pinging @elastic/secops |
|
jenkins, test this |
|
jenkins, test this |
cwurm
pushed a commit
to cwurm/beats
that referenced
this pull request
Mar 26, 2019
As discussed in elastic#11348, this shortens down entity IDs to base64-encoded 12 bytes. It makes quite the difference. I've also used the opportunity to finally standardize the `TestData` functions to (hopefully) always generate the same data (or at least to get closer to that), regardless of which system they are run on. Resolves elastic#11348. (cherry picked from commit 2f51a07)
cwurm
added
v7.0.0
and removed
needs_backport
cwurm
pushed a commit
that referenced
this pull request
Mar 26, 2019
As discussed in #11348, this shortens down entity IDs to base64-encoded 12 bytes. It makes quite the difference. I've also used the opportunity to finally standardize the `TestData` functions to (hopefully) always generate the same data (or at least to get closer to that), regardless of which system they are run on. Resolves #11348. (cherry picked from commit 2f51a07)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #11348, this shortens down entity IDs to base64-encoded 12 bytes. It makes quite the difference.
I've also used the opportunity to finally standardize the
TestDatafunctions to (hopefully) always generate the same data (or at least to get closer to that), regardless of which system they are run on.Resolves #11348.