Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the timestamp when creating the backup file #11034

Merged
merged 5 commits into from
Mar 28, 2019
Merged

Add the timestamp when creating the backup file #11034

merged 5 commits into from
Mar 28, 2019

Conversation

ph
Copy link
Contributor

@ph ph commented Mar 1, 2019

Fixes: #10031

@ph ph force-pushed the fix/add-timestamp-to-backup-file branch 3 times, most recently from e4ada90 to a9de56e Compare March 5, 2019 18:59
@ph ph added the needs_backport PR is waiting to be backported to other branches. label Mar 5, 2019
@ph
Copy link
Contributor Author

ph commented Mar 5, 2019

rebased

@ph ph requested a review from michalpristas March 25, 2019 18:21
@ph ph force-pushed the fix/add-timestamp-to-backup-file branch from a9de56e to 48db2d9 Compare March 27, 2019 21:19
@ph
Copy link
Contributor Author

ph commented Mar 27, 2019

rebased again

@ph ph removed the request for review from michalpristas March 27, 2019 21:19
@ph ph merged commit 1342d5f into elastic:master Mar 28, 2019
@ph ph mentioned this pull request Apr 5, 2019
Merged
@ph ph removed the needs_backport PR is waiting to be backported to other branches. label Apr 5, 2019
@random-issue
Copy link

Did you bother to check this when enrolling on Windows? Because when I try and run a previously working install now, it fails due to this "fix"
Saving a copy of current settings to filebeat.yml.2019-07-26T15:01:57-06:00.bak Error while enrolling: creating a backup copy of current settings: rename filebeat.yml filebeat.yml.2019-07-26T15:01:57-06:00.bak: The filename, directory name, or volume label syntax is incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urso urso urso approved these changes

Assignees
No one assigned
Labels
Management review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CM] Add timestamp to backup file
3 participants
@ph @random-issue @urso