Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network.community_id to iptables, suricata, and zeek #11005

Merged

Conversation

andrewkroh
Copy link
Member

This configures the the IPTables, Suricata, and Zeek modules to send the network.community_id
field by default. This makes it easier to correlate events related to the same flow across data sources.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/secops

This configures the the IPTables, Suricata, and Zeek modules to send the network.community_id
field by default. This makes it easier to correlate events related to the same flow across data sources.
@andrewkroh andrewkroh force-pushed the feature/filebeat/module-community-id branch from 4fb3014 to cf60759 Compare March 1, 2019 01:33
Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good!

Only one question about the use of .address, which is applicable to each of the other Zeek filesets.

- community_id:
fields:
source_ip: source.address
destination_ip: destination.address
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does the community_id processor react, when getting domain names in these IP parameters? I'd rather have this be based on destination/source.ip and skip the processor when they're missing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the values are not IP addresses then the processor will just move on and do nothing.

It's based on .address because that is what is populated by the beat rename processor. The source.ip and destination.ip get populated later by the ingest node pipeline.

@andrewkroh andrewkroh merged commit b500d0d into elastic:master Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants