[libbeat] Add image.id and account.id to EC2 add_cloud_metadata #10914

jbagel2 · 2019-02-22T23:55:07Z

Some addition data inside the same instance meta-data document is very helpful with node spanning many accounts.

elasticmachine · 2019-02-22T23:55:08Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

elasticcla · 2019-02-23T00:00:10Z

Hi @jbagel2, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

jbagel2 · 2019-02-27T15:46:25Z

@elasticcla Done and done

andrewkroh

I anticipate that we will see more requests similar to this over time. If we continue to add fields to the processor it will get bloated over time. At some point this processor will need to allow additional fields to be made configurable. Like

- add_cloud_metadata:
    extra_fields:
      ec2: {privateIp: private.ip}
      digitalocean: {interfaces.private.ipv4.ip_address: private.ip}

With that being said, I think the fields being added in this PR are generally useful to everyone. The account ID is specified in Elastic Common Schema as cloud.account.id. The image ID isn't part of the schema, but we might want to add it.

Can you please look at the unit tests for the other providers to see if their data includes an image ID or account ID and note it in this PR or update their implementations to populate the fields.
The documentation needs to be updated to show the new fields for EC2. It's in libbeat/docs/processors-using.asciidoc.
The EC2 unit test needs updated.
The instance.id field needs added to add_cloud_metadata/_meta/fields.yml. Then make update must be run.

andrewkroh · 2019-02-28T15:35:15Z

libbeat/processors/add_cloud_metadata/provider_aws_ec2.go

@@ -32,6 +32,8 @@ func newEc2MetadataFetcher(config *common.Config) (*metadataFetcher, error) {
 			"machine_type":      c.Str("instanceType"),
 			"region":            c.Str("region"),
 			"availability_zone": c.Str("availabilityZone"),
+			"accountId":         c.Str("accountId"),


This should use account.id to align with ECS.

@andrewkroh
do you mean cloud.account.id?

I guess some other fields in there could also fit the cloud ecs schema
https://www.elastic.co/guide/en/beats/filebeat/current/add-cloud-metadata.html

(looks that this task is also needed for most other cloud metadata processors)

The cloud. part gets added later. So changing the left side accoundId to account.id should make this match with the ECS cloud.account.id field.

@odacremolbap maybe https://www.elastic.co/guide/en/ecs/current/ecs-cloud.html will help!

I meant there are some other fields that looks not ECS compliant, like machine_type (should be machine.type), instance_id(should be instance.id)

am I missing something there?
I'll go through all cloud metadata processors, since I think there are a number of non ECS compliant schemas

andrewkroh · 2019-02-28T15:40:06Z

libbeat/processors/add_cloud_metadata/provider_aws_ec2.go

@@ -32,6 +32,8 @@ func newEc2MetadataFetcher(config *common.Config) (*metadataFetcher, error) {
 			"machine_type":      c.Str("instanceType"),
 			"region":            c.Str("region"),
 			"availability_zone": c.Str("availabilityZone"),
+			"accountId":         c.Str("accountId"),
+			"ami":               c.Str("imageId"),


ami is not a vendor neutral term so I wouldn't want to put it into the schema shared by all of the provider implementations. image.id would be better in my opinion. This field will need to be added to the _meta/fields.yml that's in this package.

@andrewkroh @webmat sounds like cloud.image.id would be a nice ECS candidate.
WDYT?

@odacremolbap Interesting. I'll note it down as a thing to look into.

Volume snapshots & images are available on other technology platforms than cloud providers, however. So not sure the images will end up nested under cloud necessarily.

But you can still feel free to proceed with this for now. Beats has many non-ECS fields peppered inside other ECS field sets. A bit of a risk, but not the end of the world :-)

@odacremolbap Best directly open an issue here to discuss: https://github.com/elastic/ecs

andrewkroh · 2019-02-28T15:48:34Z

I just noticed this PR is opened against 6.6. It would be better for us if you could change the target to be master (you can edit the target from this page). Then we can backport it to the other branches that need it.

jbagel2 · 2019-04-03T13:02:26Z

Update, This is still high priority for us. I have just not had cycles to get the requested changes made. You may get wind of this from elastic internal, just FYI.

odacremolbap · 2019-05-27T08:57:30Z

@jbagel2 I'll take this one over if you don't mind

houndci-bot · 2019-05-27T11:12:35Z

auditbeat/helper/hasher/hasher.go

+	SHA3_512    HashType = "sha3_512"
+	SHA512      HashType = "sha512"
+	SHA512_224  HashType = "sha512_224"
+	SHA512_256  HashType = "sha512_256"


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2019-05-27T11:12:36Z

auditbeat/helper/hasher/hasher.go

+	SHA3_384    HashType = "sha3_384"
+	SHA3_512    HashType = "sha3_512"
+	SHA512      HashType = "sha512"
+	SHA512_224  HashType = "sha512_224"


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2019-05-27T11:12:36Z

auditbeat/helper/hasher/hasher.go

+	SHA3_224    HashType = "sha3_224"
+	SHA3_256    HashType = "sha3_256"
+	SHA3_384    HashType = "sha3_384"
+	SHA3_512    HashType = "sha3_512"


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2019-05-27T11:12:36Z

auditbeat/helper/hasher/hasher.go

+	SHA384      HashType = "sha384"
+	SHA3_224    HashType = "sha3_224"
+	SHA3_256    HashType = "sha3_256"
+	SHA3_384    HashType = "sha3_384"


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2019-05-27T11:12:37Z

auditbeat/helper/hasher/hasher.go

+	SHA256      HashType = "sha256"
+	SHA384      HashType = "sha384"
+	SHA3_224    HashType = "sha3_224"
+	SHA3_256    HashType = "sha3_256"


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2019-05-27T11:12:37Z

auditbeat/helper/hasher/hasher.go

+	SHA224      HashType = "sha224"
+	SHA256      HashType = "sha256"
+	SHA384      HashType = "sha384"
+	SHA3_224    HashType = "sha3_224"


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2019-05-27T11:12:37Z

auditbeat/helper/hasher/hasher.go

+const (
+	BLAKE2B_256 HashType = "blake2b_256"
+	BLAKE2B_384 HashType = "blake2b_384"
+	BLAKE2B_512 HashType = "blake2b_512"


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2019-05-27T11:12:37Z

auditbeat/helper/hasher/hasher.go

+// Enum of hash types.
+const (
+	BLAKE2B_256 HashType = "blake2b_256"
+	BLAKE2B_384 HashType = "blake2b_384"


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2019-05-27T11:12:37Z

auditbeat/helper/hasher/hasher.go

+
+// Enum of hash types.
+const (
+	BLAKE2B_256 HashType = "blake2b_256"


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2019-05-27T11:12:42Z

dev-tools/mage/target/build/build.go

+}
+
+// BuildGoDaemon builds the go-daemon binary (use crossBuildGoDaemon).
+func BuildGoDaemon() error {


func name will be used as build.BuildGoDaemon by other packages, and that stutters; consider calling this GoDaemon

houndci-bot · 2019-05-27T11:12:45Z

filebeat/config/config.go

+	OverwritePipelines bool                 `config:"overwrite_pipelines"`
+}
+
+type Registry struct {


exported type Registry should have comment or be unexported

houndci-bot · 2019-05-27T11:12:46Z

filebeat/fileset/fileset.go

-func (fs *Fileset) GetPipeline(esVersion common.Version) (pipelineID string, content map[string]interface{}, err error) {
-	path, err := applyTemplate(fs.vars, fs.manifest.IngestPipeline, false)
+// GetPipelines returns the JSON content of the Ingest Node pipeline that parses the logs.
+func (fs *Fileset) GetPipelines(esVersion common.Version) (pipelines []pipeline, err error) {


exported method GetPipelines returns unexported type []fileset.pipeline, which can be annoying to use

houndci-bot · 2019-05-27T11:12:46Z

filebeat/config/config.go

+	OverwritePipelines bool                 `config:"overwrite_pipelines"`
+}
+
+type Registry struct {


exported type Registry should have comment or be unexported

houndci-bot · 2019-05-27T11:12:48Z

filebeat/harvester/util.go

+	LogType       = "log"
+	StdinType     = "stdin"
+	RedisType     = "redis"
+	UdpType       = "udp"


const UdpType should be UDPType

houndci-bot · 2019-05-27T11:12:48Z

filebeat/harvester/util.go

+	LogType       = "log"
+	StdinType     = "stdin"
+	RedisType     = "redis"
+	UdpType       = "udp"


const UdpType should be UDPType

houndci-bot · 2019-05-27T11:12:48Z

filebeat/input/log/file.go


 type File struct {
 	*os.File
 }

 func (File) Continuable() bool { return true }
 func (File) HasState() bool    { return true }
+func (f File) Removed() bool   { return file.IsRemoved(f.File) }


exported method File.Removed should have comment or be unexported

houndci-bot · 2019-05-27T11:12:49Z

filebeat/harvester/util.go

+	LogType       = "log"
+	StdinType     = "stdin"
+	RedisType     = "redis"
+	UdpType       = "udp"


const UdpType should be UDPType

houndci-bot · 2019-05-27T11:13:31Z

libbeat/mock/mockbeat.go

@@ -30,6 +31,8 @@ import (
 var Version = "9.9.9"
 var Name = "mockbeat"

+var Settings = instance.Settings{Name: Name, Version: Version}


exported var Settings should have comment or be unexported

houndci-bot · 2019-05-27T11:13:31Z

libbeat/mapping/field.go

+	return false
+}
+
+// Recursively generates the correct key based on the dots


comment on exported function GenerateKey should be of the form "GenerateKey ..."

houndci-bot · 2019-05-27T11:13:31Z

libbeat/mapping/field.go

+	return nil
+}
+
+func LoadFieldsYaml(path string) (Fields, error) {


exported function LoadFieldsYaml should have comment or be unexported

houndci-bot · 2019-05-27T11:13:32Z

libbeat/mapping/field.go

+
+type DynamicType struct{ Value interface{} }
+
+func (d *DynamicType) Unpack(s string) error {


exported method DynamicType.Unpack should have comment or be unexported

houndci-bot · 2019-05-27T11:13:32Z

libbeat/mapping/field.go

+	Value      string `config:"value"`
+}
+
+type DynamicType struct{ Value interface{} }


exported type DynamicType should have comment or be unexported

houndci-bot · 2019-05-27T11:13:33Z

libbeat/kibana/client.go


-	retError = extractError(result)
-	return resp.StatusCode, result, retError
+// Implements RoundTrip interface


comment on exported method Connection.RoundTrip should be of the form "RoundTrip ..."

houndci-bot · 2019-05-27T11:13:34Z

libbeat/kibana/client.go

+	return resp.StatusCode, result, retError
+}
+
+// Sends an application/json request to Kibana with appropriate kbn headers


comment on exported method Connection.Send should be of the form "Send ..."

houndci-bot · 2019-05-27T11:13:34Z

libbeat/idxmgmt/ilm/error.go

+}
+
+var (
+	ErrESVersionNotSupported = errors.New("ILM is not supported by the Elasticsearch version in use")


exported var ErrESVersionNotSupported should have comment or be unexported

houndci-bot · 2019-05-27T11:13:34Z

libbeat/dashboards/dashboards.go

-		} else {
-			importVia = useKibana
-		}
+		return errors.New("kibana configuration missing for loading dashboards.")


error strings should not be capitalized or end with punctuation or a newline

houndci-bot · 2019-05-27T11:13:35Z

libbeat/common/mapval/is_defs.go

+	})
+}
+
+func ScopedIsUnique() UniqScopeTracker {


exported function ScopedIsUnique should have comment or be unexported

houndci-bot · 2019-05-27T11:14:21Z

libbeat/common/config.go

+	return c.access().Remove(name, idx, configOpts...)
+}
+
+func (c *Config) Has(name string, idx int) (bool, error) {


exported method Config.Has should have comment or be unexported

houndci-bot · 2019-05-27T11:14:22Z

libbeat/common/config.go

@@ -188,6 +188,14 @@ func (c *Config) PathOf(field string) string {
 	return c.access().PathOf(field, ".")
 }

+func (c *Config) Remove(name string, idx int) (bool, error) {


exported method Config.Remove should have comment or be unexported

houndci-bot · 2019-05-27T11:14:22Z

libbeat/reader/readfile/timeout.go

+	err  error
+}
+
+// New returns a new timeout reader from an input line reader.


comment on exported function NewTimeoutReader should be of the form "NewTimeoutReader ..."

houndci-bot · 2019-05-27T11:14:22Z

libbeat/reader/readfile/timeout.go

+	errTimeout = errors.New("timeout")
+)
+
+// timeoutProcessor will signal some configurable timeout error if no


comment on exported type TimeoutReader should be of the form "TimeoutReader ..." (with optional leading article)

houndci-bot · 2019-05-27T11:14:23Z

libbeat/reader/readfile/strip_newline.go

+	lineEndingFunc func(*StripNewline, []byte) int
+}
+
+// New creates a new line reader stripping the last tailing newline.


comment on exported function NewStripNewline should be of the form "NewStripNewline ..."

houndci-bot · 2019-05-27T11:14:24Z

libbeat/reader/readfile/encode.go

+	Terminator LineTerminator
+}
+
+// New creates a new Encode reader from input reader by applying


comment on exported function NewEncodeReader should be of the form "NewEncodeReader ..."

houndci-bot · 2019-05-27T11:14:24Z

libbeat/reader/readfile/encode.go

+	"github.com/elastic/beats/libbeat/reader/readfile/encoding"
+)
+
+// Reader produces lines by reading lines from an io.Reader


comment on exported type EncoderReader should be of the form "EncoderReader ..." (with optional leading article)

houndci-bot · 2019-05-27T11:14:25Z

libbeat/reader/multiline/multiline.go

+type matcher func(last, current []byte) bool
+
+var (
+	sigMultilineTimeout = errors.New("multiline timeout")


error var sigMultilineTimeout should have name of the form errFoo

houndci-bot · 2019-05-27T11:14:25Z

libbeat/reader/multiline/multiline.go

+	"github.com/elastic/beats/libbeat/reader/readfile"
+)
+
+// MultiLine reader combining multiple line events into one multi-line event.


comment on exported type Reader should be of the form "Reader ..." (with optional leading article)

houndci-bot · 2019-05-27T11:14:25Z

libbeat/publisher/processing/default.go

+
+// WithBeatMeta adds beat meta information as builtin fields to a processing pipeline.
+// The `key` parameter defines the field to be used.
+func WithBeatMeta(key string) modifier {


exported func WithBeatMeta returns unexported type processing.modifier, which can be annoying to use

houndci-bot · 2019-05-27T11:15:10Z

metricbeat/module/prometheus/collector/collector.go

 	}, nil
 }

-func (m *MetricSet) Fetch() ([]common.MapStr, error) {
+func (m *MetricSet) Fetch(reporter mb.ReporterV2) {


exported method MetricSet.Fetch should have comment or be unexported

houndci-bot · 2019-05-27T11:15:11Z

metricbeat/module/system/socket_summary/sockstat_other.go

+
+// +build !linux
+
+package socket_summary


don't use an underscore in package name

houndci-bot · 2019-05-27T11:15:11Z

metricbeat/module/system/socket_summary/sockstat_linux_test.go

+
+// +build linux
+
+package socket_summary


don't use an underscore in package name

houndci-bot · 2019-05-27T11:15:11Z

metricbeat/module/system/socket_summary/sockstat_linux.go

+
+// +build linux
+
+package socket_summary


don't use an underscore in package name

houndci-bot · 2019-05-27T11:15:12Z

metricbeat/module/redis/key/key.go

+}
+
+// KeyPattern contains the information required to query keys
+type KeyPattern struct {


type name will be used as key.KeyPattern by other packages, and that stutters; consider calling this Pattern

houndci-bot · 2019-05-27T11:15:14Z

libbeat/cmd/test/output.go

 	"github.com/elastic/beats/libbeat/outputs"
 	"github.com/elastic/beats/libbeat/testing"
 )

-func GenTestOutputCmd(name, beatVersion string) *cobra.Command {
+func GenTestOutputCmd(settings instance.Settings) *cobra.Command {


exported function GenTestOutputCmd should have comment or be unexported

houndci-bot · 2019-05-27T11:15:14Z

libbeat/cmd/test/config.go

@@ -27,18 +27,18 @@ import (
 	"github.com/elastic/beats/libbeat/cmd/instance"
 )

-func GenTestConfigCmd(name, version string, beatCreator beat.Creator) *cobra.Command {
+func GenTestConfigCmd(settings instance.Settings, beatCreator beat.Creator) *cobra.Command {


exported function GenTestConfigCmd should have comment or be unexported

houndci-bot · 2019-05-27T11:15:15Z

journalbeat/beater/journalbeat.go

@@ -30,14 +30,18 @@ import (
 	"github.com/elastic/beats/libbeat/common/cfgwarn"
 	"github.com/elastic/beats/libbeat/logp"

-	conf "github.com/elastic/beats/journalbeat/config"
+	"github.com/elastic/beats/journalbeat/config"
+	_ "github.com/elastic/beats/journalbeat/include"


a blank import should be only in a main or test package, or have a comment justifying it

houndci-bot · 2019-05-27T11:15:15Z

heartbeat/cmd/root.go

 	"github.com/elastic/beats/heartbeat/beater"
+	_ "github.com/elastic/beats/heartbeat/monitors/defaults"


a blank import should be only in a main or test package, or have a comment justifying it

houndci-bot · 2019-05-27T11:15:15Z

filebeat/input/log/stdin.go

@@ -44,3 +44,4 @@ func (p Pipe) Name() string               { return p.File.Name() }
 func (p Pipe) Stat() (os.FileInfo, error) { return p.File.Stat() }
 func (p Pipe) Continuable() bool          { return false }
 func (p Pipe) HasState() bool             { return false }
+func (p Pipe) Removed() bool              { return false }


exported method Pipe.Removed should have comment or be unexported

houndci-bot · 2019-05-27T11:16:14Z

libbeat/processors/add_observer_metadata/config.go

+// specific language governing permissions and limitations
+// under the License.
+
+package add_observer_metadata


don't use an underscore in package name

houndci-bot · 2019-05-27T11:16:14Z

libbeat/processors/add_observer_metadata/add_observer_metadata_test.go

+// specific language governing permissions and limitations
+// under the License.
+
+package add_observer_metadata


don't use an underscore in package name

houndci-bot · 2019-05-27T11:16:15Z

libbeat/processors/add_observer_metadata/add_observer_metadata.go

+// specific language governing permissions and limitations
+// under the License.
+
+package add_observer_metadata


don't use an underscore in package name

houndci-bot · 2019-05-27T11:16:15Z

libbeat/processors/add_observer_metadata/config.go

+// specific language governing permissions and limitations
+// under the License.
+
+package add_observer_metadata


don't use an underscore in package name

houndci-bot · 2019-05-27T11:16:16Z

libbeat/processors/add_observer_metadata/add_observer_metadata_test.go

+// specific language governing permissions and limitations
+// under the License.
+
+package add_observer_metadata


don't use an underscore in package name

houndci-bot · 2019-05-27T11:16:16Z

libbeat/processors/add_observer_metadata/add_observer_metadata.go

+// specific language governing permissions and limitations
+// under the License.
+
+package add_observer_metadata


don't use an underscore in package name

houndci-bot · 2019-05-27T11:16:17Z

libbeat/processors/add_observer_metadata/config.go

+// specific language governing permissions and limitations
+// under the License.
+
+package add_observer_metadata


don't use an underscore in package name

houndci-bot · 2019-05-27T11:16:18Z

libbeat/processors/add_observer_metadata/add_observer_metadata_test.go

+// specific language governing permissions and limitations
+// under the License.
+
+package add_observer_metadata


don't use an underscore in package name

houndci-bot · 2019-05-27T11:16:18Z

libbeat/processors/add_observer_metadata/add_observer_metadata.go

+// specific language governing permissions and limitations
+// under the License.
+
+package add_observer_metadata


don't use an underscore in package name

odacremolbap · 2019-05-27T11:22:28Z

just noticed that you forked from elastic:6.6
I'll open a new branch with this change at master.

odacremolbap · 2019-05-29T09:51:50Z

Closing in favor of

* Just a quick addition of aws account and imageId to cloud-meta-data

25ccad7

andrewkroh added libbeat enhancement review labels Feb 28, 2019

andrewkroh requested changes Feb 28, 2019

View reviewed changes

andrewkroh added the ecs label Feb 28, 2019

andrewkroh changed the title ~~Just a quick addition of aws account and imageId to cloud-meta-data~~ [libbeat] Add image.id and account.id to EC2 add_cloud_metadata Feb 28, 2019

ruflin added Team:Integrations Label for the Integrations team [zube]: In Review labels Apr 4, 2019

andresrc assigned odacremolbap and unassigned odacremolbap May 20, 2019

houndci-bot reviewed May 27, 2019

View reviewed changes

odacremolbap force-pushed the aws_metadata_additional_fields branch from 59b8e05 to 25ccad7 Compare May 27, 2019 11:20

odacremolbap mentioned this pull request May 27, 2019

[libbeat]image.id and account.id for add_cloud_metadata EC2 #12307

Merged

odacremolbap closed this May 29, 2019

zube bot added [zube]: Done and removed [zube]: In Review labels May 29, 2019

andresrc removed the [zube]: Done label Jun 3, 2019


		type DynamicType struct{ Value interface{} }

		func (d *DynamicType) Unpack(s string) error {

		"github.com/elastic/beats/heartbeat/beater"
		_ "github.com/elastic/beats/heartbeat/monitors/defaults"

[libbeat] Add image.id and account.id to EC2 add_cloud_metadata #10914

[libbeat] Add image.id and account.id to EC2 add_cloud_metadata #10914

Conversation

jbagel2 commented Feb 22, 2019

elasticmachine commented Feb 22, 2019

elasticcla commented Feb 23, 2019

jbagel2 commented Feb 27, 2019 • edited Loading

andrewkroh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

odacremolbap May 23, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrewkroh commented Feb 28, 2019 • edited Loading

jbagel2 commented Apr 3, 2019

odacremolbap commented May 27, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

odacremolbap commented May 27, 2019

odacremolbap commented May 29, 2019

jbagel2 commented Feb 27, 2019 •

edited

Loading

odacremolbap May 23, 2019 •

edited

Loading

andrewkroh commented Feb 28, 2019 •

edited

Loading