Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more info to message logged when a duplicated symlink file is found #10845

Merged
merged 3 commits into from
Feb 21, 2019
Merged

Add more info to message logged when a duplicated symlink file is found #10845

merged 3 commits into from
Feb 21, 2019

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Feb 20, 2019

There was a typo in the message that was logged when symlinks are enabled and the same files are found. I also added more context to the message, so it is more informative.
The new message is the following:

Same file found as symlink and original. Skipping file: test.log (as it is same as: test-2016.log)

@kvch kvch requested a review from a team as a code owner February 20, 2019 15:09
adriansr
adriansr approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@adriansr adriansr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kvch kvch merged commit 06b53f7 into elastic:master Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriansr adriansr adriansr approved these changes

Assignees
No one assigned
Labels
enhancement Filebeat Filebeat review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kvch @adriansr