Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squelch duplicate HTTP packet loss error messages #10709

Merged

Conversation

andrewkroh
Copy link
Member

Each time a gap is detected a new error message is appended. One message is
sufficient to know that packet loss occurred so stop adding errors after the first.

I was seeing events with many errors.

   "error": {
         "message": [
           "Packet loss while capturing the response",
           "Packet loss while capturing the response",
          ....
          ]
   }

@andrewkroh andrewkroh added review Packetbeat needs_backport PR is waiting to be backported to other branches. labels Feb 13, 2019
@andrewkroh andrewkroh requested a review from a team as a code owner February 13, 2019 06:59
Each time a gap is detected a new error message is appended. One message is
sufficient to know that packet loss occurred so stop adding errors after the first.

I was seeing events with many errors.

       "error": {
             "message": [
               "Packet loss while capturing the response",
               "Packet loss while capturing the response",
              ....
              ]
       }
@andrewkroh andrewkroh force-pushed the feature/pb/squelch-packet-loss-errors branch from 6641435 to 07349e5 Compare February 13, 2019 07:01
Copy link
Contributor

@adriansr adriansr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkroh
Copy link
Member Author

jenkins, test this

@andrewkroh andrewkroh merged commit 7a515ea into elastic:master Feb 13, 2019
@andrewkroh andrewkroh removed the needs_backport PR is waiting to be backported to other branches. label Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants