[Metricbeat] Release nats module as GA #10281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
added
module
review
Metricbeat
jsoriano
approved these changes
Jan 23, 2019
|
@ruflin nice to hear and thank you for the amazing collaboration on this 🙂 ! Just to let you known that @skatsaounis is going to add some improvements on #10235, regarding the fields and their format in order to make the metrics' visualization more meaningful. |
ruflin
commented
Jan 23, 2019
| - Release mongodb.metrics and mongodb.replstatus as GA. {pull}10242[10242] | ||
| - Release mysql.galera_status as GA. {pull}10242[10242] | ||
| - Release postgresql.statement as GA. {pull}10242[10242] | ||
| - Release RabbitMQ Metricbeat module GA. {pull}10165[10165] | ||
| - Release Dropwizard module as GA. {pull}10240[10240] | ||
| - Release Graphite module as GA. {pull}10240[10240] | ||
| - Release http.server metricset as GA. {pull}10240[10240] | ||
| - Making RabbitMQ Metricbeat module GA. {pull}10165[10165] |
There was a problem hiding this comment.
@jsoriano FYI I'm removing RabbitMQ twice here as it is already on line 204.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this module locally and couldn't find any issue. I suggest we release this as GA especially as soon we also have dashboards: #10235
@ChrsMark @skatsaounis @MichaelKatsoulis Thank you so much for this very high quality contributions. Any concern around making this GA?