Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to ECS Filebeat modules populating http size and duration metrics #10188

Merged
merged 11 commits into from
Jan 23, 2019
Merged

Migrate to ECS Filebeat modules populating http size and duration metrics #10188

merged 11 commits into from
Jan 23, 2019

Commits on Jan 23, 2019

  1. Transition all remaining http size metrics to ECS

    Mathieu Martin committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    8fc16ed View commit details
    Browse the repository at this point in the history

  2. Add missing long coercion for bytes in apache module

    Mathieu Martin committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    13d98d1 View commit details
    Browse the repository at this point in the history

  3. Calculate event.duration for IIS access logs

    Mathieu Martin committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    f30c6ec View commit details
    Browse the repository at this point in the history

  4. Remove original request durations in other access log modules. 

    I'm also reusing the same pattern of using a temp field, prior to computing `event.duration`. This will reduce compilations, as both the `script` and `if` arguments are exactly the same code, from one module to the other. Only the `scale` param needs to be adjusted, depending if one has millis, micros, etc.
    Mathieu Martin committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    fb8bd44 View commit details
    Browse the repository at this point in the history

  5. Perform all aliases for http size metrics

    Mathieu Martin committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    60fcd61 View commit details
    Browse the repository at this point in the history

  6. Remove http time metric fields, documenting this in ecs-migration.yml

    Mathieu Martin committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    bced622 View commit details
    Browse the repository at this point in the history

  7. Fix temp duration common processor by using temp.duration 

    Not nested under the special `_ingest`
    Mathieu Martin committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    571cb40 View commit details
    Browse the repository at this point in the history

  8. Formalize the idea of documenting how the duration fields are migrating. 

    Based on my suggestion over on Andrew's PR: elastic#10193 (comment)
    Mathieu Martin committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    e8a0824 View commit details
    Browse the repository at this point in the history

  9. Changelog for the two migrated fields under http.

    Mathieu Martin committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    a2994e7 View commit details
    Browse the repository at this point in the history

  10. Add other entries to changelog. Perhaps too chatty?

    Mathieu Martin committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    a39361f View commit details
    Browse the repository at this point in the history

  11. Final changelog. One entry for bytes, one for duration.

    Mathieu Martin committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    51534ce View commit details
    Browse the repository at this point in the history