Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heartbeat] Alias http.url.raw to url.full #10005

Closed
wants to merge 1 commit into from
Closed

[Heartbeat] Alias http.url.raw to url.full #10005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dev-tools/ecs-migration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,6 +685,10 @@
to: url.full
alias: true

- from: http.url.raw
to: url.full
alias: true

- from: tcp.port
to: url.port
alias: true
6 changes: 6 additions & 0 deletions heartbeat/monitors/active/http/_meta/fields.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,12 @@
migration: true
description: >
Service url used by monitor.
- name: url.raw
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if this will actually work to have a field which was a multi field before pointing to an alias. Problem is that we have now an alias http.url and http.url.raw which I would think is not possible in a template.

If you run make update and try to load the template, you will definitively find out.

type: alias
path: url.full
migration: true
description: >
Service url used by monitor.
- name: rtt
type: group
description: >
Expand Down