Log event failed in the encoder

elastic · Nov 27, 2018 · 9748535 · 9748535
1 parent c972608
commit 9748535
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/libbeat/outputs/logstash/async.go b/libbeat/outputs/logstash/async.go
@@ -254,5 +254,4 @@ func (r *msgRef) dec() {
 
 	r.batch.RetryEvents(r.slice)
 	logp.Err("Failed to publish events caused by: %v", err)
-	logp.Debug("logstash", "Failed events: %v", r.slice)
 }
diff --git a/libbeat/outputs/logstash/enc.go b/libbeat/outputs/logstash/enc.go
@@ -24,7 +24,11 @@ import (
 
 func makeLogstashEventEncoder(info beat.Info, escapeHTML bool, index string) func(interface{}) ([]byte, error) {
 	enc := json.New(false, escapeHTML, info.Version)
-	return func(event interface{}) ([]byte, error) {
-		return enc.Encode(index, event.(*beat.Event))
+	return func(event interface{}) (d []byte, err error) {
+		d, err = enc.Encode(index, event.(*beat.Event))
+		if err != nil {
+			debugf("Failed to encode event: %v", event)
+		}
+		return
 	}
 }
diff --git a/libbeat/outputs/logstash/sync.go b/libbeat/outputs/logstash/sync.go
@@ -153,7 +153,6 @@ func (c *syncClient) Publish(batch publisher.Batch) error {
 			_ = c.Close()
 
 			logp.Err("Failed to publish events caused by: %v", err)
-			logp.Debug("logstash", "Failed events: %v", events)
 
 			rest := len(events)
 			st.Failed(rest)