Skip to content

Commit

Permalink
Merge pull request #6669 from ruflin/aerospike-default
Browse files Browse the repository at this point in the history
Set namespace as default metricset in Aerospike module
  • Loading branch information
jsoriano committed Mar 28, 2018
2 parents ce66abe + f9b66c8 commit 2b58e4a
Show file tree
Hide file tree
Showing 8 changed files with 12 additions and 15 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,7 @@ https://github.com/elastic/beats/compare/v6.0.0-beta2...master[Check the HEAD di
- Set `collector` as default metricset in Prometheus module. {pull}6636[6636]
- Set `mntr` as default metricset in Zookeeper module. {pull}6674[6674]
- Set default metricsets in vSphere module. {pull}6676[6676]
- Set `namespace` as default metricset in Aerospike module. {pull}6669[6669]

*Packetbeat*

Expand Down
5 changes: 1 addition & 4 deletions metricbeat/docs/modules/aerospike.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ This file is generated! See scripts/docs_collector.py

beta[]

The Aerospike module uses the http://www.aerospike.com/docs/reference/info[Info command] to collect metrics.
The Aerospike module uses the http://www.aerospike.com/docs/reference/info[Info command] to collect metrics. The default metricset is `namespace`.

[float]
=== Compatibility
Expand All @@ -25,9 +25,6 @@ in <<configuration-metricbeat>>. Here is an example configuration:
----
metricbeat.modules:
- module: aerospike
metricsets: ["namespace"]
enabled: false
period: 10s
hosts: ["localhost:3000"]
----

Expand Down
2 changes: 1 addition & 1 deletion metricbeat/metricbeat.reference.yml
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ metricbeat.modules:
#------------------------------ Aerospike Module -----------------------------
- module: aerospike
metricsets: ["namespace"]
enabled: false
enabled: true
period: 10s
hosts: ["localhost:3000"]

Expand Down
5 changes: 5 additions & 0 deletions metricbeat/module/aerospike/_meta/config.reference.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
- module: aerospike
metricsets: ["namespace"]
enabled: true
period: 10s
hosts: ["localhost:3000"]
3 changes: 0 additions & 3 deletions metricbeat/module/aerospike/_meta/config.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,2 @@
- module: aerospike
metricsets: ["namespace"]
enabled: false
period: 10s
hosts: ["localhost:3000"]
2 changes: 1 addition & 1 deletion metricbeat/module/aerospike/_meta/docs.asciidoc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
The Aerospike module uses the http://www.aerospike.com/docs/reference/info[Info command] to collect metrics.
The Aerospike module uses the http://www.aerospike.com/docs/reference/info[Info command] to collect metrics. The default metricset is `namespace`.

[float]
=== Compatibility
Expand Down
6 changes: 3 additions & 3 deletions metricbeat/module/aerospike/namespace/namespace.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ import (
// init registers the MetricSet with the central registry.
// The New method will be called after the setup of the module and before starting to fetch data
func init() {
if err := mb.Registry.AddMetricSet("aerospike", "namespace", New); err != nil {
panic(err)
}
mb.Registry.MustAddMetricSet("aerospike", "namespace", New,
mb.DefaultMetricSet(),
)
}

// MetricSet type defines all fields of the MetricSet
Expand Down
3 changes: 0 additions & 3 deletions metricbeat/modules.d/aerospike.yml.disabled
Original file line number Diff line number Diff line change
@@ -1,5 +1,2 @@
- module: aerospike
metricsets: ["namespace"]
enabled: false
period: 10s
hosts: ["localhost:3000"]

0 comments on commit 2b58e4a

Please sign in to comment.