Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Babel configuration is not used #604

Closed
JulianKniephoff opened this issue May 5, 2020 · 1 comment
Closed

Babel configuration is not used #604

JulianKniephoff opened this issue May 5, 2020 · 1 comment
Labels
priority:low Low priority type:feature-improvement This would improve or enhance an existing feature

Comments

@JulianKniephoff
Copy link
Member

JulianKniephoff commented May 5, 2020 •
edited
Loading

This is because of create-react-app, and is also the case for the ESLint configuration, but there is a fix for that coming with my PR later.

The Babel side of things is not so easily fixed, unfortunately. Apparently you can do it with sth. like customize-cra and/or react-app-rewired; the method blessed by the CRA people is to fork react-scripts.

Or we can just eject ...

Apparently this is not really a problem at the moment, but this also potentially prevents us from using Babel plugins. This just happened to me, trying to use private methods.
@LukasKalbertodt LukasKalbertodt added type:feature-improvement This would improve or enhance an existing feature priority:low Low priority labels May 6, 2020
@LukasKalbertodt
Copy link
Member

Irrelevant since/fixed by #1069

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:low Low priority type:feature-improvement This would improve or enhance an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JulianKniephoff @LukasKalbertodt