Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waveform appearance in dark mode #1096

Closed
JulianKniephoff opened this issue Sep 5, 2023 · 3 comments · Fixed by #1119
Closed

Waveform appearance in dark mode #1096

JulianKniephoff opened this issue Sep 5, 2023 · 3 comments · Fixed by #1119

Comments

@JulianKniephoff
Copy link
Member

@lkiesow wrote in #1069 (comment):

Screenshot from 2023-08-24 09-22-45

I think the black waveform box looks a bit odd. Especially since there is already a box around that box. Can we try switching to the same background color as the inner box? Something like this:

Screenshot from 2023-08-24 09-22-45

@oas777 replied in TODO:

I consider this a canvas holding a box (cf. editor) and I wouldn't want this removed, at least not in the light mode:
grafik

Discuss!

@LukasKalbertodt
Copy link
Member

Personally, I don't think it's a problem and I would just keep it as is. If no one else will comment here agreeing with Lars in the next while, I will close this issue (to clean the issue list a bit).

@narickmann
Copy link
Contributor

I would leave it as it is. Without the box, it feels like sth is missing (at least a border).
As a compromise, you could make the box a little brighter (i.e. a dark gray, but only in dark mode)? But then we could have too little contrast.

@lkiesow
Copy link
Contributor

lkiesow commented Sep 14, 2023

I think what's weird is that you essentially have a box in a box, with both having a different background color.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants