From 0fa6f8fcdd63b4b49d10e5e1cea295dde880dbae Mon Sep 17 00:00:00 2001
From: Emmett Lalish <elalish@google.com>
Date: Tue, 9 May 2023 12:35:01 -0700
Subject: [PATCH 1/7] make-manifold working

---
 bindings/wasm/examples/gltf-io.js             | 107 ++++++++-----
 bindings/wasm/examples/make-manifold.html     | 140 ++++++++++++++++++
 .../wasm/manifold-encapsulated-types.d.ts     |   1 +
 3 files changed, 212 insertions(+), 36 deletions(-)
 create mode 100644 bindings/wasm/examples/make-manifold.html

diff --git a/bindings/wasm/examples/gltf-io.js b/bindings/wasm/examples/gltf-io.js
index faed21c33..6d936a56d 100644
--- a/bindings/wasm/examples/gltf-io.js
+++ b/bindings/wasm/examples/gltf-io.js
@@ -32,23 +32,17 @@ export function setupIO(io) {
   return io.registerExtensions([EXTManifold]);
 }
 
-export function readMesh(mesh, attributes, materials) {
-  if (attributes.length < 1 || attributes[0] !== 'POSITION')
-    throw new Error('First attribute must be "POSITION".');
-
-  const primitives = mesh.listPrimitives();
-  if (primitives.length === 0) {
-    return {};
-  }
-
-  const numProp = attributes.map((def) => attributeDefs[def].components)
-                      .reduce((a, b) => a + b);
-  const position = primitives[0].getAttribute('POSITION');
-  const numVert = position.getCount()
-  const vertProperties = new Float32Array(numProp * numVert);
+function readPrimitive(primitive, numProp, attributes) {
+  const position = primitive.getAttribute('POSITION');
+  const numVert = position.getCount();
+  const vertProperties = [];
   let offset = 0;
   for (const attribute of attributes) {
-    const accessor = primitives[0].getAttribute(attribute);
+    if (attribute === 'SKIP') {
+      offset += attributeDefs[attribute].components;
+      continue;
+    }
+    const accessor = primitive.getAttribute(attribute);
     const array = accessor.getArray();
     const size = accessor.getElementSize();
     for (let i = 0; i < numVert; ++i) {
@@ -58,37 +52,78 @@ export function readMesh(mesh, attributes, materials) {
     }
     offset += size;
   }
+  return vertProperties;
+}
+
+export function readMesh(mesh, attributes, materials) {
+  const primitives = mesh.listPrimitives();
+  if (primitives.length === 0) {
+    return {};
+  }
 
+  if (attributes.length === 0) {
+    const attributeSet = new Set();
+    for (const primitive of primitives) {
+      const semantics = primitive.listSemantics();
+      for (const semantic of semantics) {
+        attributeSet.add(semantic);
+      }
+    }
+    for (const semantic in attributeDefs) {
+      if (attributeSet.has(semantic)) {
+        attributes.push(semantic);
+        attributeSet.delete(semantic);
+      }
+    }
+    for (const semantic of attributeSet.keys()) {
+      attributes.push(semantic);
+    }
+  }
+
+  if (attributes.length < 1 || attributes[0] !== 'POSITION')
+    throw new Error('First attribute must be "POSITION".');
+
+  const numProp = attributes.map((def) => attributeDefs[def].components)
+                      .reduce((a, b) => a + b);
+
+  const manifoldPrimitive = mesh.getExtension('EXT_manifold');
+
+  const vertPropArray = [];
   const triVertArray = [];
-  const runIndexArray = [0];
-  for (const primitive of primitives) {
-    if (primitive.getAttribute('POSITION') === position) {
+  const runIndexArray = [];
+  const mergeFromVert = [];
+  const mergeToVert = [];
+  if (manifoldPrimitive != null) {
+    runIndexArray.push(0);
+    vertPropArray.push(...readPrimitive(primitives[0], numProp, attributes));
+    for (const primitive of primitives) {
       triVertArray.push(...primitive.getIndices().getArray());
       runIndexArray.push(triVertArray.length);
       materials.push(primitive.getMaterial());
-    } else {
-      console.log('primitives do not share accessors!');
+    }
+    const mergeTriVert = manifoldPrimitive.getMergeIndices()?.getArray() ?? [];
+    const mergeTo = manifoldPrimitive.getMergeValues()?.getArray() ?? [];
+    const vert2merge = new Map();
+    for (const [i, idx] of mergeTriVert.entries()) {
+      vert2merge.set(triVertArray[idx], mergeTo[i]);
+    }
+    for (const [from, to] of vert2merge.entries()) {
+      mergeFromVert.push(from);
+      mergeToVert.push(to);
+    }
+  } else {
+    for (const primitive of primitives) {
+      const numVert = vertPropArray.length / numProp;
+      vertPropArray.push(...readPrimitive(primitive, numProp, attributes));
+      triVertArray.push(
+          ...primitive.getIndices().getArray().map((i) => i + numVert));
+      materials.push(primitive.getMaterial());
     }
   }
+  const vertProperties = new Float32Array(vertPropArray);
   const triVerts = new Uint32Array(triVertArray);
   const runIndex = new Uint32Array(runIndexArray);
 
-  const manifoldPrimitive = mesh.getExtension('EXT_manifold');
-  const mergeTriVert =
-      manifoldPrimitive ? manifoldPrimitive.getMergeIndices().getArray() : [];
-  const mergeTo =
-      manifoldPrimitive ? manifoldPrimitive.getMergeValues().getArray() : [];
-  const vert2merge = new Map();
-  for (const [i, idx] of mergeTriVert.entries()) {
-    vert2merge.set(triVerts[idx], mergeTo[i]);
-  }
-  const mergeFromVert = [];
-  const mergeToVert = [];
-  for (const [from, to] of vert2merge.entries()) {
-    mergeFromVert.push(from);
-    mergeToVert.push(to);
-  }
-
   return {
     numProp,
     triVerts,
diff --git a/bindings/wasm/examples/make-manifold.html b/bindings/wasm/examples/make-manifold.html
new file mode 100644
index 000000000..e382ff090
--- /dev/null
+++ b/bindings/wasm/examples/make-manifold.html
@@ -0,0 +1,140 @@
+<!doctype html>
+<html lang="en">
+
+<head>
+  <title>Make manifold glTF</title>
+  <meta charset="utf-8">
+  <meta name="viewport" content="width=device-width, initial-scale=1">
+  <link rel="shortcut icon" type="image/png" href="https://elalish.github.io/manifold/samples/models/favicon.png" />
+  <style>
+    body {
+      margin: 0;
+      background-color: #f7f7f7;
+      font-family: 'Rubik', sans-serif;
+      font-size: 16px;
+      line-height: 24px;
+      color: rgba(0, 0, 0, .87);
+      font-weight: 400;
+      -webkit-font-smoothing: antialiased;
+    }
+
+    p {
+      max-width: 700px;
+      margin: 1em;
+      text-align: left;
+    }
+
+    model-viewer {
+      display: block;
+      width: 100vw;
+      height: 100vw;
+      max-width: 600px;
+      max-height: 600px;
+    }
+  </style>
+</head>
+
+<body>
+  <p>Load a glTF/GLB model and our <a href="https://github.com/elalish/manifold">Manifold</a> library will attempt to
+    merge it into a set of manifold objects. You can download the new GLB which will have our <a
+      href="https://github.com/KhronosGroup/glTF/pull/2286">EXT_manifold</a> extension, thus preserving the manifold
+    data without losing any mesh properties.</p>
+  <input type="file" id="input">
+  <button id="download">Download manifold GLB</button>
+  <model-viewer camera-controls shadow-intensity="1" alt="Output of mesh Boolean operation">
+    <span slot="poster">Drop a GLB here</span>
+  </model-viewer>
+</body>
+<script type="importmap">
+  {
+    "imports": {
+      "@gltf-transform/core": "https://cdn.jsdelivr.net/npm/@gltf-transform/core@3.2.1/+esm",
+      "@gltf-transform/functions": "https://cdn.jsdelivr.net/npm/@gltf-transform/functions@3.2.1/+esm"
+    }
+  }
+</script>
+<script type="module" src="https://ajax.googleapis.com/ajax/libs/model-viewer/2.0.1/model-viewer.min.js"></script>
+<script type="module">
+  import { WebIO } from '@gltf-transform/core';
+  import { prune } from '@gltf-transform/functions';
+  import { SimpleDropzone } from 'https://cdn.jsdelivr.net/npm/simple-dropzone@0.8.3/+esm';
+  import { readMesh, writeMesh, setupIO } from './gltf-io.js';
+  import Module from './built/manifold.js';
+
+  const io = setupIO(new WebIO());
+
+  const wasm = await Module();
+  wasm.setup();
+
+  const mv = document.querySelector('model-viewer');
+  const inputEl = document.querySelector('#input');
+  const dropCtrl = new SimpleDropzone(mv, inputEl);
+
+  dropCtrl.on('drop', async ({ files }) => {
+    for (const [path, file] of files) {
+      const filename = file.name.toLowerCase();
+      if (filename.match(/\.(gltf|glb)$/)) {
+        const blobURL = URL.createObjectURL(file);
+        push2MV(await readGLB(blobURL));
+        URL.revokeObjectURL(blobURL);
+        break;
+      }
+    }
+  });
+
+  let objectURL = null;
+
+  const downloadButton = document.querySelector('#download');
+  downloadButton.onclick = function () {
+    const link = document.createElement('a');
+    link.download = 'manifold.glb';
+    link.href = objectURL;
+    link.click();
+  };
+
+  async function push2MV(doc) {
+    const glb = await io.writeBinary(doc);
+
+    const blob = new Blob([glb], { type: 'application/octet-stream' });
+    URL.revokeObjectURL(objectURL);
+    objectURL = URL.createObjectURL(blob);
+    mv.src = objectURL;
+  }
+
+  async function readGLB(url) {
+    const docIn = await io.read(url);
+    const nodes = docIn.getRoot().listNodes();
+    for (const node of nodes) {
+      const attributes = [];
+      const mesh = node.getMesh();
+      if (!mesh) {
+        continue;
+      }
+
+      const materials = [];
+      const tmpMesh = readMesh(mesh, attributes, materials);
+      tmpMesh.runOriginalID = [];
+      const firstID = wasm.reserveIDs(materials.length);
+      for (let i = 0; i < materials.length; ++i) {
+        tmpMesh.runOriginalID.push(firstID + i);
+      }
+      const manifoldMesh = new wasm.Mesh(tmpMesh);
+
+      manifoldMesh.merge();
+
+      try {
+        const manifold = wasm.Manifold(manifoldMesh);
+        mesh.dispose();
+        node.setMesh(writeMesh(docIn, manifold.getMesh(), attributes, materials));
+      } catch (e) {
+        console.log(mesh.getName(), e);
+      }
+    }
+
+    await docIn.transform(prune());
+
+    return docIn;
+  }
+</script>
+
+</html>
\ No newline at end of file
diff --git a/bindings/wasm/manifold-encapsulated-types.d.ts b/bindings/wasm/manifold-encapsulated-types.d.ts
index 351c20f27..b4afd92b8 100644
--- a/bindings/wasm/manifold-encapsulated-types.d.ts
+++ b/bindings/wasm/manifold-encapsulated-types.d.ts
@@ -435,6 +435,7 @@ export class Mesh {
   get numTri(): number;
   get numVert(): number;
   get numRun(): number;
+  merge(): boolean;
   verts(tri: number): SealedUint32Array<3>;
   position(vert: number): SealedFloat32Array<3>;
   extras(vert: number): Float32Array;

From d1b0e27406e28fb2938cda5db26f70922942e52b Mon Sep 17 00:00:00 2001
From: Emmett Lalish <elalish@google.com>
Date: Tue, 9 May 2023 13:00:26 -0700
Subject: [PATCH 2/7] prettier

---
 bindings/wasm/examples/make-manifold.html | 19 +++++++++++++++----
 1 file changed, 15 insertions(+), 4 deletions(-)

diff --git a/bindings/wasm/examples/make-manifold.html b/bindings/wasm/examples/make-manifold.html
index e382ff090..52e326461 100644
--- a/bindings/wasm/examples/make-manifold.html
+++ b/bindings/wasm/examples/make-manifold.html
@@ -8,7 +8,6 @@
   <link rel="shortcut icon" type="image/png" href="https://elalish.github.io/manifold/samples/models/favicon.png" />
   <style>
     body {
-      margin: 0;
       background-color: #f7f7f7;
       font-family: 'Rubik', sans-serif;
       font-size: 16px;
@@ -30,6 +29,15 @@
       height: 100vw;
       max-width: 600px;
       max-height: 600px;
+      border: 3px solid black;
+      border-radius: 10px;
+    }
+
+    #poster {
+      position: absolute;
+      left: 50%;
+      top: 50%;
+      transform: translate3d(-50%, -50%, 0);
     }
   </style>
 </head>
@@ -41,15 +49,16 @@
     data without losing any mesh properties.</p>
   <input type="file" id="input">
   <button id="download">Download manifold GLB</button>
-  <model-viewer camera-controls shadow-intensity="1" alt="Output of mesh Boolean operation">
-    <span slot="poster">Drop a GLB here</span>
+  <model-viewer camera-controls shadow-intensity="1" alt="Loaded GLB model">
+    <span id="poster" slot="poster">Drop a GLB here</span>
   </model-viewer>
 </body>
 <script type="importmap">
   {
     "imports": {
       "@gltf-transform/core": "https://cdn.jsdelivr.net/npm/@gltf-transform/core@3.2.1/+esm",
-      "@gltf-transform/functions": "https://cdn.jsdelivr.net/npm/@gltf-transform/functions@3.2.1/+esm"
+      "@gltf-transform/functions": "https://cdn.jsdelivr.net/npm/@gltf-transform/functions@3.2.1/+esm",
+      "@gltf-transform/extensions": "https://cdn.jsdelivr.net/npm/@gltf-transform/extensions@3.2.1/+esm"
     }
   }
 </script>
@@ -57,11 +66,13 @@
 <script type="module">
   import { WebIO } from '@gltf-transform/core';
   import { prune } from '@gltf-transform/functions';
+  import { KHRONOS_EXTENSIONS } from '@gltf-transform/extensions';
   import { SimpleDropzone } from 'https://cdn.jsdelivr.net/npm/simple-dropzone@0.8.3/+esm';
   import { readMesh, writeMesh, setupIO } from './gltf-io.js';
   import Module from './built/manifold.js';
 
   const io = setupIO(new WebIO());
+  io.registerExtensions(KHRONOS_EXTENSIONS);
 
   const wasm = await Module();
   wasm.setup();

From 9a9411697748172d6efd0d02e09a58404930cf29 Mon Sep 17 00:00:00 2001
From: Emmett Lalish <elalish@google.com>
Date: Tue, 9 May 2023 13:11:25 -0700
Subject: [PATCH 3/7] fixed stack exceeded

---
 bindings/wasm/examples/gltf-io.js | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/bindings/wasm/examples/gltf-io.js b/bindings/wasm/examples/gltf-io.js
index 6d936a56d..42a2dd015 100644
--- a/bindings/wasm/examples/gltf-io.js
+++ b/bindings/wasm/examples/gltf-io.js
@@ -88,16 +88,16 @@ export function readMesh(mesh, attributes, materials) {
 
   const manifoldPrimitive = mesh.getExtension('EXT_manifold');
 
-  const vertPropArray = [];
-  const triVertArray = [];
+  let vertPropArray = [];
+  let triVertArray = [];
   const runIndexArray = [];
   const mergeFromVert = [];
   const mergeToVert = [];
   if (manifoldPrimitive != null) {
     runIndexArray.push(0);
-    vertPropArray.push(...readPrimitive(primitives[0], numProp, attributes));
+    vertPropArray = readPrimitive(primitives[0], numProp, attributes);
     for (const primitive of primitives) {
-      triVertArray.push(...primitive.getIndices().getArray());
+      triVertArray = [...triVertArray, ...primitive.getIndices().getArray()];
       runIndexArray.push(triVertArray.length);
       materials.push(primitive.getMaterial());
     }
@@ -114,9 +114,12 @@ export function readMesh(mesh, attributes, materials) {
   } else {
     for (const primitive of primitives) {
       const numVert = vertPropArray.length / numProp;
-      vertPropArray.push(...readPrimitive(primitive, numProp, attributes));
-      triVertArray.push(
-          ...primitive.getIndices().getArray().map((i) => i + numVert));
+      vertPropArray =
+          [...vertPropArray, ...readPrimitive(primitive, numProp, attributes)];
+      triVertArray = [
+        ...triVertArray,
+        ...primitive.getIndices().getArray().map((i) => i + numVert)
+      ];
       materials.push(primitive.getMaterial());
     }
   }

From e2b33e6a455971924380cb0451f11838845ade20 Mon Sep 17 00:00:00 2001
From: Emmett Lalish <elalish@google.com>
Date: Tue, 9 May 2023 13:32:35 -0700
Subject: [PATCH 4/7] download only manifolds

---
 bindings/wasm/examples/make-manifold.html | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/bindings/wasm/examples/make-manifold.html b/bindings/wasm/examples/make-manifold.html
index 52e326461..39e004101 100644
--- a/bindings/wasm/examples/make-manifold.html
+++ b/bindings/wasm/examples/make-manifold.html
@@ -44,11 +44,12 @@
 
 <body>
   <p>Load a glTF/GLB model and our <a href="https://github.com/elalish/manifold">Manifold</a> library will attempt to
-    merge it into a set of manifold objects. You can download the new GLB which will have our <a
-      href="https://github.com/KhronosGroup/glTF/pull/2286">EXT_manifold</a> extension, thus preserving the manifold
-    data without losing any mesh properties.</p>
+    merge it into a set of manifold objects. If the model is water-tight, you can download the new GLB which will have
+    our <a href="https://github.com/KhronosGroup/glTF/pull/2286">EXT_manifold</a> extension, thus preserving the
+    manifold data without losing any mesh properties. If the download button is disabled, it means your model has open
+    edges and does not represent a solid object.</p>
   <input type="file" id="input">
-  <button id="download">Download manifold GLB</button>
+  <button id="download" disabled>Download manifold GLB</button>
   <model-viewer camera-controls shadow-intensity="1" alt="Loaded GLB model">
     <span id="poster" slot="poster">Drop a GLB here</span>
   </model-viewer>
@@ -113,6 +114,8 @@
   }
 
   async function readGLB(url) {
+    downloadButton.disabled = true;
+    let failure = false;
     const docIn = await io.read(url);
     const nodes = docIn.getRoot().listNodes();
     for (const node of nodes) {
@@ -139,9 +142,15 @@
         node.setMesh(writeMesh(docIn, manifold.getMesh(), attributes, materials));
       } catch (e) {
         console.log(mesh.getName(), e);
+        failure = true;
+        break;
       }
     }
 
+    if (!failure) {
+      downloadButton.disabled = false;
+    }
+
     await docIn.transform(prune());
 
     return docIn;

From dd8a36e13cae129dfbb6667b7ce33270453a659b Mon Sep 17 00:00:00 2001
From: Emmett Lalish <elalish@google.com>
Date: Thu, 11 May 2023 10:36:35 -0700
Subject: [PATCH 5/7] keep any meshes that are manifold

---
 bindings/wasm/CMakeLists.txt                  |  2 +-
 .../built/manifold-encapsulated-types.d.ts    |  1 +
 bindings/wasm/examples/make-manifold.html     | 75 +++++++++++++------
 3 files changed, 56 insertions(+), 22 deletions(-)

diff --git a/bindings/wasm/CMakeLists.txt b/bindings/wasm/CMakeLists.txt
index 8ad7581db..14cf9c702 100644
--- a/bindings/wasm/CMakeLists.txt
+++ b/bindings/wasm/CMakeLists.txt
@@ -20,7 +20,7 @@ add_executable(manifoldjs bindings.cpp)
 set_source_files_properties(bindings.cpp OBJECT_DEPENDS
   ${CMAKE_CURRENT_SOURCE_DIR}/bindings.js)
 target_link_libraries(manifoldjs manifold sdf cross_section polygon)
-target_compile_options(manifoldjs PRIVATE ${MANIFOLD_FLAGS} -fexceptions)
+target_compile_options(manifoldjs PRIVATE ${MANIFOLD_FLAGS})
 target_link_options(manifoldjs PUBLIC --pre-js ${CMAKE_CURRENT_SOURCE_DIR}/bindings.js --bind -sALLOW_TABLE_GROWTH=1
   -sEXPORTED_RUNTIME_METHODS=addFunction,removeFunction -sMODULARIZE=1 -sEXPORT_ES6=1)
 
diff --git a/bindings/wasm/examples/built/manifold-encapsulated-types.d.ts b/bindings/wasm/examples/built/manifold-encapsulated-types.d.ts
index 351c20f27..b4afd92b8 100644
--- a/bindings/wasm/examples/built/manifold-encapsulated-types.d.ts
+++ b/bindings/wasm/examples/built/manifold-encapsulated-types.d.ts
@@ -435,6 +435,7 @@ export class Mesh {
   get numTri(): number;
   get numVert(): number;
   get numRun(): number;
+  merge(): boolean;
   verts(tri: number): SealedUint32Array<3>;
   position(vert: number): SealedFloat32Array<3>;
   extras(vert: number): Float32Array;
diff --git a/bindings/wasm/examples/make-manifold.html b/bindings/wasm/examples/make-manifold.html
index 39e004101..8aa1ca099 100644
--- a/bindings/wasm/examples/make-manifold.html
+++ b/bindings/wasm/examples/make-manifold.html
@@ -31,6 +31,7 @@
       max-height: 600px;
       border: 3px solid black;
       border-radius: 10px;
+      margin-top: 5px;
     }
 
     #poster {
@@ -46,10 +47,14 @@
   <p>Load a glTF/GLB model and our <a href="https://github.com/elalish/manifold">Manifold</a> library will attempt to
     merge it into a set of manifold objects. If the model is water-tight, you can download the new GLB which will have
     our <a href="https://github.com/KhronosGroup/glTF/pull/2286">EXT_manifold</a> extension, thus preserving the
-    manifold data without losing any mesh properties. If the download button is disabled, it means your model has open
-    edges and does not represent a solid object.</p>
+    manifold data without losing any mesh properties.</p>
+  <p> If the View Manifold GLB checkbox is enabled, then some meshes in the model have open edges and don't represent a
+    solid object. Check this box to see only the manifold parts, which will also enable them to be downloaded. If the
+    download button is still disabled, it means there were no manifold meshes found. </p>
   <input type="file" id="input">
   <button id="download" disabled>Download manifold GLB</button>
+  <input type="checkbox" id="viewFinal" disabled>
+  <label for="viewFinal">View Manifold GLB</label>
   <model-viewer camera-controls shadow-intensity="1" alt="Loaded GLB model">
     <span id="poster" slot="poster">Drop a GLB here</span>
   </model-viewer>
@@ -80,42 +85,72 @@
 
   const mv = document.querySelector('model-viewer');
   const inputEl = document.querySelector('#input');
+  const downloadButton = document.querySelector('#download');
+  const checkbox = document.querySelector('#viewFinal');
   const dropCtrl = new SimpleDropzone(mv, inputEl);
 
+  let inputGLBurl = null;
+  let outputGLBurl = null;
+  let allManifold = true;
+  let anyManifold = false;
+
   dropCtrl.on('drop', async ({ files }) => {
     for (const [path, file] of files) {
       const filename = file.name.toLowerCase();
       if (filename.match(/\.(gltf|glb)$/)) {
-        const blobURL = URL.createObjectURL(file);
-        push2MV(await readGLB(blobURL));
-        URL.revokeObjectURL(blobURL);
+        URL.revokeObjectURL(inputGLBurl);
+        inputGLBurl = URL.createObjectURL(file);
+        writeGLB(await readGLB(inputGLBurl));
+        updateUI();
         break;
       }
     }
   });
 
-  let objectURL = null;
+  function updateUI() {
+    if (allManifold) {
+      checkbox.checked = true;
+      checkbox.disabled = true;
+    } else if (anyManifold) {
+      checkbox.checked = false;
+      checkbox.disabled = false;
+    } else {
+      checkbox.checked = false;
+      checkbox.disabled = true;
+    }
+    onClick();
+  }
+
+  checkbox.onclick = onClick;
+
+  function onClick() {
+    mv.src = checkbox.checked ? outputGLBurl : inputGLBurl;
+    downloadButton.disabled = !checkbox.checked;
+  };
 
-  const downloadButton = document.querySelector('#download');
   downloadButton.onclick = function () {
     const link = document.createElement('a');
     link.download = 'manifold.glb';
-    link.href = objectURL;
+    link.href = outputGLBurl;
     link.click();
   };
 
-  async function push2MV(doc) {
+  async function writeGLB(doc) {
+    URL.revokeObjectURL(outputGLBurl);
+    if (!anyManifold) {
+      return;
+    }
     const glb = await io.writeBinary(doc);
 
     const blob = new Blob([glb], { type: 'application/octet-stream' });
-    URL.revokeObjectURL(objectURL);
-    objectURL = URL.createObjectURL(blob);
-    mv.src = objectURL;
+    outputGLBurl = URL.createObjectURL(blob);
   }
 
   async function readGLB(url) {
-    downloadButton.disabled = true;
-    let failure = false;
+    allManifold = false;
+    anyManifold = false;
+    updateUI();
+    allManifold = true;
     const docIn = await io.read(url);
     const nodes = docIn.getRoot().listNodes();
     for (const node of nodes) {
@@ -133,24 +168,22 @@
         tmpMesh.runOriginalID.push(firstID + i);
       }
       const manifoldMesh = new wasm.Mesh(tmpMesh);
+      mesh.dispose();
 
       manifoldMesh.merge();
 
       try {
+        // Test manifoldness - will throw if not.
         const manifold = wasm.Manifold(manifoldMesh);
-        mesh.dispose();
         node.setMesh(writeMesh(docIn, manifold.getMesh(), attributes, materials));
+        manifold.delete();
+        anyManifold = true;
       } catch (e) {
         console.log(mesh.getName(), e);
-        failure = true;
-        break;
+        allManifold = false;
       }
     }
 
-    if (!failure) {
-      downloadButton.disabled = false;
-    }
-
     await docIn.transform(prune());
 
     return docIn;

From 07e0b329a02a598e9905b70a54a21b0b625ab9f9 Mon Sep 17 00:00:00 2001
From: Emmett Lalish <elalish@google.com>
Date: Fri, 12 May 2023 22:58:51 -0700
Subject: [PATCH 6/7] fixed extension accessor writer

---
 bindings/wasm/examples/gltf-io.js         | 15 ++++++++++-----
 bindings/wasm/examples/make-manifold.html |  2 +-
 bindings/wasm/examples/manifold-gltf.js   | 22 +++++++++++++---------
 3 files changed, 24 insertions(+), 15 deletions(-)

diff --git a/bindings/wasm/examples/gltf-io.js b/bindings/wasm/examples/gltf-io.js
index 42a2dd015..8bc79342a 100644
--- a/bindings/wasm/examples/gltf-io.js
+++ b/bindings/wasm/examples/gltf-io.js
@@ -144,14 +144,13 @@ export function writeMesh(doc, manifoldMesh, attributes, materials) {
   const buffer = doc.getRoot().listBuffers()[0];
   const manifoldExtension = doc.createExtension(EXTManifold);
 
-  const indices = doc.createAccessor('indices')
-                      .setBuffer(buffer)
-                      .setType(Accessor.Type.SCALAR)
-                      .setArray(manifoldMesh.triVerts);
-
   const mesh = doc.createMesh();
   const numPrimitive = manifoldMesh.runIndex.length - 1;
   for (let run = 0; run < numPrimitive; ++run) {
+    const indices = doc.createAccessor('indices')
+                        .setBuffer(buffer)
+                        .setType(Accessor.Type.SCALAR)
+                        .setArray(new Uint32Array());
     const primitive = doc.createPrimitive().setIndices(indices);
     const material = materials[run];
     if (material) {
@@ -197,6 +196,12 @@ export function writeMesh(doc, manifoldMesh, attributes, materials) {
 
   const manifoldPrimitive = manifoldExtension.createManifoldPrimitive();
   mesh.setExtension('EXT_manifold', manifoldPrimitive);
+
+  const indices = doc.createAccessor('indices')
+                      .setBuffer(buffer)
+                      .setType(Accessor.Type.SCALAR)
+                      .setArray(manifoldMesh.triVerts);
+  manifoldPrimitive.setIndices(indices);
   manifoldPrimitive.setRunIndex(manifoldMesh.runIndex);
 
   const vert2merge = [...Array(manifoldMesh.numVert).keys()];
diff --git a/bindings/wasm/examples/make-manifold.html b/bindings/wasm/examples/make-manifold.html
index 8aa1ca099..978b24c55 100644
--- a/bindings/wasm/examples/make-manifold.html
+++ b/bindings/wasm/examples/make-manifold.html
@@ -100,7 +100,7 @@
       if (filename.match(/\.(gltf|glb)$/)) {
         URL.revokeObjectURL(inputGLBurl);
         inputGLBurl = URL.createObjectURL(file);
-        writeGLB(await readGLB(inputGLBurl));
+        await writeGLB(await readGLB(inputGLBurl));
         updateUI();
         break;
       }
diff --git a/bindings/wasm/examples/manifold-gltf.js b/bindings/wasm/examples/manifold-gltf.js
index 0e6b9a7bc..6b42e0428 100644
--- a/bindings/wasm/examples/manifold-gltf.js
+++ b/bindings/wasm/examples/manifold-gltf.js
@@ -53,6 +53,14 @@ export class ManifoldPrimitive extends ExtensionProperty {
   setRunIndex(runIndex) {
     return this.set('runIndex', runIndex);
   }
+
+  setIndices(indices) {
+    return this.setRef('indices', indices);
+  }
+
+  getIndices() {
+    return this.getRef('indices');
+  }
 }
 
 export class EXTManifold extends Extension {
@@ -124,7 +132,7 @@ export class EXTManifold extends Extension {
 
       const existingPrimitive = meshDef.primitives[0];
       const primitive = {
-        indices: existingPrimitive.indices,
+        indices: context.accessorIndexMap.get(manifoldPrimitive.getIndices()),
         mode: existingPrimitive.mode,
         attributes: {'POSITION': existingPrimitive.attributes['POSITION']}
       };
@@ -150,14 +158,10 @@ export class EXTManifold extends Extension {
       }
 
       for (let i = 0; i < numPrimitive; ++i) {
-        meshDef.primitives[i].indices = json.accessors.length;
-        json.accessors.push({
-          type: 'SCALAR',
-          componentType: indices.componentType,
-          count: runIndex[i + 1] - runIndex[i],
-          bufferView: indices.bufferView,
-          byteOffset: 4 * runIndex[i]
-        });
+        const accessor = json.accessors[meshDef.primitives[i].indices];
+        accessor.bufferView = indices.bufferView;
+        accessor.byteOffset = indices.byteOffset + 4 * runIndex[i];
+        accessor.count = runIndex[i + 1] - runIndex[i];
       }
 
       meshDef.extensions = meshDef.extensions || {};

From b28b2ab133a471597e26a8dc9b6e8abd248f76d8 Mon Sep 17 00:00:00 2001
From: Emmett Lalish <elalish@google.com>
Date: Sat, 13 May 2023 14:12:56 -0700
Subject: [PATCH 7/7] fix read-write roundtrip

---
 bindings/wasm/examples/gltf-io.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bindings/wasm/examples/gltf-io.js b/bindings/wasm/examples/gltf-io.js
index 8bc79342a..449a5835d 100644
--- a/bindings/wasm/examples/gltf-io.js
+++ b/bindings/wasm/examples/gltf-io.js
@@ -90,11 +90,10 @@ export function readMesh(mesh, attributes, materials) {
 
   let vertPropArray = [];
   let triVertArray = [];
-  const runIndexArray = [];
+  const runIndexArray = [0];
   const mergeFromVert = [];
   const mergeToVert = [];
   if (manifoldPrimitive != null) {
-    runIndexArray.push(0);
     vertPropArray = readPrimitive(primitives[0], numProp, attributes);
     for (const primitive of primitives) {
       triVertArray = [...triVertArray, ...primitive.getIndices().getArray()];
@@ -120,6 +119,7 @@ export function readMesh(mesh, attributes, materials) {
         ...triVertArray,
         ...primitive.getIndices().getArray().map((i) => i + numVert)
       ];
+      runIndexArray.push(triVertArray.length);
       materials.push(primitive.getMaterial());
     }
   }