From dd15d3b1cf5e42349e3349450ed986b91bd5463c Mon Sep 17 00:00:00 2001
From: Alin Voinea <contact@avoinea.com>
Date: Wed, 16 Sep 2020 18:05:43 +0300
Subject: [PATCH] Make text editor aware of layout required and
 disableNewBlocks settings

---
 src/blocks/Text/TextBlockEdit.jsx           |  2 +-
 src/blocks/Text/extensions/breakList.js     |  9 +++
 src/blocks/Text/extensions/insertBreak.js   |  8 ++
 src/blocks/Text/keyboard/backspaceInList.js |  5 ++
 src/blocks/Text/keyboard/joinBlocks.js      | 88 ++++-----------------
 5 files changed, 37 insertions(+), 75 deletions(-)

diff --git a/src/blocks/Text/TextBlockEdit.jsx b/src/blocks/Text/TextBlockEdit.jsx
index 333dad84..aa53d596 100644
--- a/src/blocks/Text/TextBlockEdit.jsx
+++ b/src/blocks/Text/TextBlockEdit.jsx
@@ -232,7 +232,7 @@ const TextBlockEdit = (props) => {
           />
         )}
       </Dropzone>
-      {!detached && !data.plaintext && (
+      {!detached && !data.plaintext && !data.disableNewBlocks && (
         <Button
           basic
           icon
diff --git a/src/blocks/Text/extensions/breakList.js b/src/blocks/Text/extensions/breakList.js
index 5b2d3b1c..a3352d30 100644
--- a/src/blocks/Text/extensions/breakList.js
+++ b/src/blocks/Text/extensions/breakList.js
@@ -60,6 +60,15 @@ export const breakList = (editor) => {
       return; // applies default behaviour, as defined in insertBreak.js extension
     }
 
+    if (parent) {
+      const blockProps = editor.getBlockProps();
+      const { data } = blockProps;
+      // Don't add new block if not allowed
+      if (data?.disableNewBlocks) {
+        return insertBreak();
+      }
+    }
+
     // TODO: while this is interesting as a tech demo, I'm not sure that this is
     // what we really want (break lists in two separate blocks)
 
diff --git a/src/blocks/Text/extensions/insertBreak.js b/src/blocks/Text/extensions/insertBreak.js
index 86563914..c83eb847 100644
--- a/src/blocks/Text/extensions/insertBreak.js
+++ b/src/blocks/Text/extensions/insertBreak.js
@@ -28,6 +28,14 @@ export const withSplitBlocksOnBreak = (editor) => {
       const block = Editor.parent(editor, editor.selection);
 
       if (block) {
+        const blockProps = editor.getBlockProps();
+        const { data } = blockProps;
+
+        // Don't add new block if not allowed
+        if (data?.disableNewBlocks) {
+          return insertBreak();
+        }
+
         const [top, bottom] = splitEditorInTwoFragments(editor);
         setEditorContent(editor, top);
         ReactEditor.blur(editor);
diff --git a/src/blocks/Text/keyboard/backspaceInList.js b/src/blocks/Text/keyboard/backspaceInList.js
index aba777d4..5d4a5c10 100644
--- a/src/blocks/Text/keyboard/backspaceInList.js
+++ b/src/blocks/Text/keyboard/backspaceInList.js
@@ -39,6 +39,11 @@ export function backspaceInList({ editor, event }) {
   // If the cursor is at list block start, do something different:
   if (isCursorAtListBlockStart(editor)) {
     const { slate } = settings;
+    const blockProps = editor.getBlockProps();
+    const { data } = blockProps;
+
+    // Can't split if block is required
+    if (data?.required) return;
 
     // Raise all LI-s as direct children of the editor.
     Transforms.liftNodes(editor, {
diff --git a/src/blocks/Text/keyboard/joinBlocks.js b/src/blocks/Text/keyboard/joinBlocks.js
index 97f5ea5d..271d6e1b 100644
--- a/src/blocks/Text/keyboard/joinBlocks.js
+++ b/src/blocks/Text/keyboard/joinBlocks.js
@@ -32,6 +32,7 @@ export function joinWithPreviousBlock({ editor, event }) {
     onChangeBlock,
     onDeleteBlock,
     onSelectBlock,
+    data,
   } = blockProps;
 
   const { formContext } = editor;
@@ -46,6 +47,12 @@ export function joinWithPreviousBlock({ editor, event }) {
   // If the previous block is not Slate Text, do nothing.
   if (otherBlock['@type'] !== 'slate') return;
 
+  // Can't join if the previous block is required
+  if (otherBlock?.required) return;
+
+  // Can't join/remove this block if it's required
+  if (data?.required) return;
+
   // From here on, the previous block is surely Slate Text.
   event.stopPropagation();
   event.preventDefault();
@@ -137,6 +144,7 @@ export function joinWithNextBlock({ editor, event }) {
     onChangeBlock,
     onDeleteBlock,
     onSelectBlock,
+    data,
   } = blockProps;
 
   const { formContext } = editor;
@@ -152,6 +160,12 @@ export function joinWithNextBlock({ editor, event }) {
   // instead of 'slate'.)
   if (otherBlock['@type'] !== 'slate') return;
 
+  // Can't join/remove this block if it's required
+  if (data?.required) return;
+
+  // Can't join if the next block is required
+  if (otherBlock?.required) return;
+
   // From here on, the next block is surely Slate Text.
   event.stopPropagation();
   event.preventDefault();
@@ -198,80 +212,6 @@ export function joinWithNextBlock({ editor, event }) {
   return true;
 }
 
-/**
- * Join current block with neighbor block, if the blocks are compatible.
- * @todo This seems to be dead code that should be removed or transformed into a
- * combination of `joinWithPreviousBlock` and `joinWithNextBlock` which are
- * written above.
- */
-export function joinWithNeighborBlock(
-  getNeighborVoltoBlock,
-  getCursorPosition,
-  isValidOp,
-  mergeOp,
-) {
-  /**
-   *
-   */
-  return ({ editor, event }) => {
-    // TODO: read block values not from editor properties, but from block
-    // properties
-    const blockProps = editor.getBlockProps();
-    const {
-      block,
-      index,
-      saveSlateBlockSelection,
-      onChangeBlock,
-      onDeleteBlock,
-      onSelectBlock,
-    } = blockProps;
-
-    const { formContext } = editor;
-    const properties = formContext.contextData.formData;
-
-    const [otherBlock = {}, otherBlockId] = getNeighborVoltoBlock(
-      index,
-      properties,
-    );
-
-    if (!isValidOp(editor)) return;
-
-    if (otherBlock['@type'] !== 'slate') return;
-
-    event.stopPropagation();
-    event.preventDefault();
-
-    mergeOp(editor, otherBlock);
-
-    const selection = JSON.parse(JSON.stringify(editor.selection));
-    const combined = JSON.parse(JSON.stringify(editor.children));
-
-    // TODO: don't remove undo history, etc Should probably save both undo
-    // histories, so that the blocks are split, the undos can be restored??
-    // TODO: after Enter, the current filled-with-previous-block block is
-    // visible for a fraction of second
-
-    const cursor = getCursorPosition(otherBlock, selection);
-    saveSlateBlockSelection(otherBlockId, cursor);
-
-    // setTimeout ensures setState has been successfully executed in Form.jsx.
-    // See https://github.com/plone/volto/issues/1519
-    setTimeout(() => {
-      onChangeBlock(otherBlockId, {
-        '@type': 'slate',
-        value: combined,
-        plaintext: serializeNodesToText(combined || []),
-      });
-      setTimeout(() => {
-        onDeleteBlock(block, false);
-        onSelectBlock(otherBlockId);
-      });
-    });
-
-    return true;
-  };
-}
-
 /**
  * @param {object} block The Volto object representing the configuration and
  * contents of a Volto Block of type Slate Text.