From cb9a81fd0a794f9c26afe0c3d09dfe2b8fd9f896 Mon Sep 17 00:00:00 2001 From: dana-cfc4 Date: Thu, 15 Jun 2023 17:55:02 +0300 Subject: [PATCH] refactor: Fix issues identified by Sonarqube Refs #254220 --- src/ColumnsBlock/ColumnsBlockEdit.jsx | 13 ++++++++----- src/ColumnsBlock/ColumnsBlockView.test.js | 1 - src/ColumnsBlock/EditBlockWrapper.jsx | 1 - src/Widgets/ColumnsWidget.jsx | 3 +-- src/Widgets/Slider.jsx | 1 - src/index.js | 1 - src/utils.js | 1 - 7 files changed, 9 insertions(+), 12 deletions(-) diff --git a/src/ColumnsBlock/ColumnsBlockEdit.jsx b/src/ColumnsBlock/ColumnsBlockEdit.jsx index 5f2d37c..53141c7 100644 --- a/src/ColumnsBlock/ColumnsBlockEdit.jsx +++ b/src/ColumnsBlock/ColumnsBlockEdit.jsx @@ -1,18 +1,21 @@ import React from 'react'; import { defineMessages, FormattedMessage, injectIntl } from 'react-intl'; import { compose } from 'redux'; -import { Grid, Segment } from 'semantic-ui-react'; +import { Grid, Segment, Button } from 'semantic-ui-react'; import { isEmpty, without } from 'lodash'; -import { SidebarPortal, BlocksToolbar, Icon } from '@plone/volto/components'; // BlocksForm, Icon, -import { BlockDataForm } from '@plone/volto/components'; +import { + SidebarPortal, + BlocksToolbar, + Icon, + BlockDataForm, + BlocksForm, +} from '@plone/volto/components'; // BlocksForm, Icon, import { emptyBlocksForm, getBlocksLayoutFieldname, } from '@plone/volto/helpers'; import { setSidebarTab } from '@plone/volto/actions'; import { connect } from 'react-redux'; -import { BlocksForm } from '@plone/volto/components'; -import { Button } from 'semantic-ui-react'; import config from '@plone/volto/registry'; import cx from 'classnames'; diff --git a/src/ColumnsBlock/ColumnsBlockView.test.js b/src/ColumnsBlock/ColumnsBlockView.test.js index 367e500..06f0dd6 100644 --- a/src/ColumnsBlock/ColumnsBlockView.test.js +++ b/src/ColumnsBlock/ColumnsBlockView.test.js @@ -1,5 +1,4 @@ import React from 'react'; -// import renderer from 'react-test-renderer'; import configureStore from 'redux-mock-store'; import { Provider } from 'react-intl-redux'; import config from '@plone/volto/registry'; diff --git a/src/ColumnsBlock/EditBlockWrapper.jsx b/src/ColumnsBlock/EditBlockWrapper.jsx index 0c00dc7..213a686 100644 --- a/src/ColumnsBlock/EditBlockWrapper.jsx +++ b/src/ColumnsBlock/EditBlockWrapper.jsx @@ -36,7 +36,6 @@ class EditBlockWrapper extends React.Component { } componentDidMount() { - // console.log('mount editblockwrapper', this.props.blockProps.block); document.addEventListener('mousedown', this.handleClickOutside, false); } diff --git a/src/Widgets/ColumnsWidget.jsx b/src/Widgets/ColumnsWidget.jsx index 2e7d58e..74aa3ec 100644 --- a/src/Widgets/ColumnsWidget.jsx +++ b/src/Widgets/ColumnsWidget.jsx @@ -3,8 +3,7 @@ import { FormattedMessage } from 'react-intl'; import { v4 as uuid } from 'uuid'; import { omit, without } from 'lodash'; import move from 'lodash-move'; -import { Icon, FormFieldWrapper } from '@plone/volto/components'; -import { DragDropList } from '@plone/volto/components'; +import { Icon, FormFieldWrapper, DragDropList } from '@plone/volto/components'; import { emptyBlocksForm } from '@plone/volto/helpers'; import dragSVG from '@plone/volto/icons/drag.svg'; diff --git a/src/Widgets/Slider.jsx b/src/Widgets/Slider.jsx index c49b6d3..413e1c0 100644 --- a/src/Widgets/Slider.jsx +++ b/src/Widgets/Slider.jsx @@ -487,7 +487,6 @@ const SliderWidget = (props) => { settings={{ ...settings, onChange: (value) => { - // console.log('onchange', value); onChange(id, value); }, }} diff --git a/src/index.js b/src/index.js index 8741e21..54dfe24 100644 --- a/src/index.js +++ b/src/index.js @@ -87,7 +87,6 @@ export default function install(config) { tocEntry: (block = {}, tocData) => { // integration with volto-block-toc const headlines = tocData.levels || ['h1', 'h2', 'h3', 'h4', 'h5', 'h6']; - // const column_blocks = block?.data?.blocks || {}; let entries = []; const sorted_column_blocks = getBlocks(block?.data || {}); sorted_column_blocks.forEach((column_block) => { diff --git a/src/utils.js b/src/utils.js index 9e03f27..19062c5 100644 --- a/src/utils.js +++ b/src/utils.js @@ -8,7 +8,6 @@ import config from '@plone/volto/registry'; const columnConfig = { cloneData(blockData) { - // console.log('column', blockData); return cloneFormData(blockData); }, };