Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeScript DTO generator #15078

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Fix TypeScript DTO generator #15078

merged 1 commit into from
Nov 5, 2019

Conversation

evidolob
Copy link
Contributor

@evidolob evidolob commented Nov 4, 2019

What does this PR do?

This PR do next:

  • Fix generation of TypeScript interface if original Java interface has java.io. Serializable as parameter or field type. All java.io. Serializable converted as string | number | boolean union type.
  • Adds getPreviewUrl method in CommandDto interface.

What issues does this PR fix or reference?

#14756

Release Notes

Docs PR

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@evidolob evidolob self-assigned this Nov 4, 2019
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Nov 4, 2019
@che-bot
Copy link
Contributor

che-bot commented Nov 4, 2019

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Nov 4, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@evidolob
Copy link
Contributor Author

evidolob commented Nov 5, 2019

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Nov 5, 2019

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

@evidolob evidolob merged commit b91572a into master Nov 5, 2019
@evidolob evidolob deleted the fix-dto-generator branch November 5, 2019 07:56
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 5, 2019
@che-bot che-bot added this to the 7.4.0 milestone Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants