Disable autosave on Devfile editor page #14913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akurinnoy
requested review from
ashumilova,
l0rd,
nickboldt and
rhopp
as code owners
che-bot
added
status/code-review
olexii4
reviewed
Oct 17, 2019
dashboard/src/app/workspaces/workspace-details/devfile/workspace-devfile-editor.controller.ts
Outdated
Show resolved
Hide resolved
|
@slemeur |
olexii4
approved these changes
Oct 19, 2019
|
crw-ci-test |
|
ci-build |
akurinnoy
force-pushed
the
disable-autosave
branch
2 times, most recently
from
f0e9f31
to
0b275e8
Compare
|
Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/2747//Selenium_20tests_20report/) doesn't show any regression against this Pull request. Failed |
SkorikSergey
approved these changes
Oct 22, 2019
|
ci-build |
akurinnoy
force-pushed
the
disable-autosave
branch
from
67b2ac5
to
f70bb44
Compare
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
|
crw-ci-test |
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
|
ci-build |
|
ci-test |
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
|
ci-test |
slemeur
approved these changes
Oct 28, 2019
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Dialog window can have now only one button. Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
akurinnoy
force-pushed
the
disable-autosave
branch
from
f70bb44
to
98f1e43
Compare
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
che-bot
removed
the
status/code-review
skabashnyuk
pushed a commit
that referenced
this pull request
Jan 3, 2020
* Remove autosave on Devfile editor page Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * update ConfirmDialogService Dialog window can have now only one button. Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * fix applying changes to running workspace Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Oleksii Kurinnyi okurinny@redhat.com
What does this PR do?
This PR disables autosave feature on devfile editor page.
Initially, autosave was added in order not to lose unsaved workspace configuration changes, mainly because of going to another Dashboard page. Now, if workspace has unsaved changes, user is not able to go to another Dashboard page nor start/stop workspace.
Demo
What issues does this PR fix or reference?
fixes #13982