Generate a new SSH key if no keys are registered while ssh mount #14767

vinokurig · 2019-10-03T14:41:46Z

What does this PR do?

If no SSH keys are registered by user, a new SSH key will be automatically generated and mounted to all containers when a workspace starts.

What issues does this PR fix or reference?

fixes #14411

Release Notes

Docs PR

che-bot · 2019-10-03T14:54:46Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14767
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

che-bot · 2019-10-03T15:34:08Z

E2E tests of Eclipse Che Multiuser on OCP has been successful:

Build details
Test report
docker image: eclipseche/che-server:14767

dmytro-ndp · 2019-10-03T15:40:05Z

crw-ci-test

che-bot · 2019-10-03T15:53:13Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14767
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

dmytro-ndp · 2019-10-03T15:56:13Z

crw-ci-test

che-bot · 2019-10-03T16:09:25Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14767
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

Signed-off-by: Igor Vinokur <ivinokur@redhat.com>

che-bot · 2019-10-04T05:53:47Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14767
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

vinokurig · 2019-10-04T06:12:55Z

crw-ci-test

che-bot · 2019-10-04T06:27:03Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14767
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

che-bot · 2019-10-04T06:38:35Z

E2E tests of Eclipse Che Multiuser on OCP has been successful:

Build details
Test report
docker image: eclipseche/che-server:14767

vinokurig · 2019-10-04T13:03:37Z

crw-ci-test

che-bot · 2019-10-04T13:18:33Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14767
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

che-bot · 2019-10-04T13:34:19Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

build details
"che-server" docker image: maxura/che-server:14767
test artifacts
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "crw-ci-test" to rerun the test.

dmytro-ndp · 2019-10-04T14:08:50Z

crw-ci-test

l0rd · 2019-10-04T15:16:05Z

@vinokurig it worked fine on minikube but failed on OpenShift. That's Theia container log:

root INFO Theia app listening on http://0.0.0.0:3100.
root INFO unzipping the plug-in 'eclipse_che_ports_plugin.theia' to directory: /tmp/theia-unpacked/eclipse_che_ports_plugin.theia
root INFO unzipping the plug-in 'eclipse_che_theia_containers_plugin.theia' to directory: /tmp/theia-unpacked/eclipse_che_theia_containers_plugin.theia
root INFO unzipping the plug-in 'eclipse_che_theia_factory_plugin.theia' to directory: /tmp/theia-unpacked/eclipse_che_theia_factory_plugin.theia
root INFO unzipping the plug-in 'eclipse_che_theia_ssh_plugin.theia' to directory: /tmp/theia-unpacked/eclipse_che_theia_ssh_plugin.theia
root INFO unzipping the plug-in 'eclipse_che_welcome_plugin.theia' to directory: /tmp/theia-unpacked/eclipse_che_welcome_plugin.theia
root INFO unzipping the plug-in 'task_plugin.theia' to directory: /tmp/theia-unpacked/task_plugin.theia
root INFO unzipping the plug-in 'theia_yeoman_plugin.theia' to directory: /tmp/theia-unpacked/theia_yeoman_plugin.theia
root INFO unzipping the VS Code extension 'vscode-git-1.3.0.1.vsix' to directory: /tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix
root INFO PluginTheiaDirectoryHandler: accepting plugin with path /tmp/theia-unpacked/eclipse_che_ports_plugin.theia
root INFO PluginTheiaDirectoryHandler: accepting plugin with path /tmp/theia-unpacked/eclipse_che_theia_containers_plugin.theia
root INFO PluginTheiaDirectoryHandler: accepting plugin with path /tmp/theia-unpacked/eclipse_che_theia_factory_plugin.theia
root INFO PluginTheiaDirectoryHandler: accepting plugin with path /tmp/theia-unpacked/eclipse_che_theia_ssh_plugin.theia
root INFO PluginTheiaDirectoryHandler: accepting plugin with path /tmp/theia-unpacked/eclipse_che_welcome_plugin.theia
root INFO PluginTheiaDirectoryHandler: accepting plugin with path /tmp/theia-unpacked/task_plugin.theia
root INFO PluginTheiaDirectoryHandler: accepting plugin with path /tmp/theia-unpacked/theia_yeoman_plugin.theia
root INFO PluginTheiaDirectoryHandler: accepting plugin with path /tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix
root INFO Resolved "vscode-git-1.3.0.1.vsix" to a VS Code extension "git@1.0.0" with engines: { vscode: '^1.5.0' }
root INFO PluginTheiaDirectoryHandler: accepting plugin with path /plugins/sidecars
root ERROR Failed to load plugin dependencies from '/plugins/sidecars' path Error: ENOENT: no such file or directory, open '/plugins/sidecars/package.json'
root INFO Deploying backend plugin "@eclipse-che/ports-plugin@0.0.1" from "/tmp/theia-unpacked/eclipse_che_ports_plugin.theia/lib/ports-plugin.js"
root INFO Deploying backend plugin "@eclipse-che/theia-containers-plugin@0.0.2" from "/tmp/theia-unpacked/eclipse_che_theia_containers_plugin.theia/lib/containers-plugin.js"
root INFO Deploying backend plugin "@eclipse-che/theia-factory-plugin@0.0.1" from "/tmp/theia-unpacked/eclipse_che_theia_factory_plugin.theia/lib/factory-plugin.js"
root INFO Deploying backend plugin "@eclipse-che/theia-ssh-plugin@0.0.1" from "/tmp/theia-unpacked/eclipse_che_theia_ssh_plugin.theia/lib/ssh-plugin-backend.js"
root INFO Deploying backend plugin "@eclipse-che/welcome-plugin@0.0.1" from "/tmp/theia-unpacked/eclipse_che_welcome_plugin.theia/lib/welcome-plugin.js"
root INFO Deploying backend plugin "task-plugin@0.0.1" from "/tmp/theia-unpacked/task_plugin.theia/lib/task-plugin-backend.js"
root INFO Deploying backend plugin "@theia/yeoman-plugin@0.0.1-1562576566" from "/tmp/theia-unpacked/theia_yeoman_plugin.theia/lib/theia-yeoman-plugin-backend-plugin.js"
root INFO Deploying backend plugin "git@1.0.0" from "/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/main"
root ERROR Uncaught Exception:  TypeError: Cannot read property 'model' of undefined
root ERROR TypeError: Cannot read property 'model' of undefined
    at /home/theia/node_modules/@eclipse-che/theia-remote/lib/node/hosted-plugin-remote.js:202:78
    at Array.forEach (<anonymous>)
    at HostedPluginRemote.handleLocalMessage (/home/theia/node_modules/@eclipse-che/theia-remote/lib/node/hosted-plugin-remote.js:201:29)
    at Websocket.websocket.onMessage (/home/theia/node_modules/@eclipse-che/theia-remote/lib/node/hosted-plugin-remote.js:152:23)
    at WebSocket.<anonymous> (/home/theia/node_modules/@eclipse-che/theia-remote/lib/node/websocket.js:38:19)
    at WebSocket.emit (events.js:198:13)
    at Receiver.receiverOnMessage (/home/theia/node_modules/ws/lib/websocket.js:720:20)
    at Receiver.emit (events.js:198:13)
    at Receiver.dataMessage (/home/theia/node_modules/ws/lib/receiver.js:414:14)
    at Receiver.getData (/home/theia/node_modules/ws/lib/receiver.js:346:17)
root WARN Failed to resolve module: @types/body-parser
root WARN Failed to resolve module: @types/bunyan
root WARN Failed to resolve module: @types/express
root WARN Failed to resolve module: @types/fs-extra
root WARN Failed to resolve module: @types/lodash.debounce
root WARN Failed to resolve module: @types/lodash.throttle
root WARN Failed to resolve module: @types/react
root WARN Failed to resolve module: @types/react-dom
root WARN Failed to resolve module: @types/react-virtualized
root WARN Failed to resolve module: @types/route-parser
root WARN Failed to resolve module: @types/ws
root WARN Failed to resolve module: @types/yargs
root WARN Failed to resolve module: font-awesome
root WARN Failed to resolve module: react
root WARN Failed to resolve module: react-dom
root WARN Failed to resolve module: react-virtualized
root WARN Failed to resolve module: @types/rimraf
root WARN Failed to resolve module: @types/tar-fs
root WARN Failed to resolve module: @types/touch
root WARN Failed to resolve module: @types/uuid
root WARN Failed to resolve module: @typefox/monaco-editor-core
root WARN Failed to resolve module: @types/base64-arraybuffer
root WARN Failed to resolve module: @theia/monaco
root WARN Failed to resolve module: @types/p-debounce
root WARN Failed to resolve module: @types/mime-types
root WARN Failed to resolve module: @types/diff
root WARN Failed to resolve module: @types/request
root WARN Failed to resolve module: @types/highlight.js
root WARN Failed to resolve module: @types/markdown-it
root WARN Failed to resolve module: @types/markdown-it-anchor
root WARN A handler with prefix term  is already registered.
root INFO [nsfw-watcher: 31] Started watching: /home/theia/.theia
root INFO [nsfw-watcher: 31] Started watching: /projects
root WARN e.onStart is slow, took: 500.51999999777763 ms
root INFO [nsfw-watcher: 31] Started watching: /projects
root ERROR Request getDeployedPluginIds failed with error: Cannot read property 'model' of undefined TypeError: Cannot read property 'model' of undefined
    at /home/theia/node_modules/@eclipse-che/theia-remote/lib/node/hosted-plugin-remote.js:232:170
    at Array.map (<anonymous>)
    at HostedPluginRemote.<anonymous> (/home/theia/node_modules/@eclipse-che/theia-remote/lib/node/hosted-plugin-remote.js:232:107)
    at step (/home/theia/node_modules/@eclipse-che/theia-remote/lib/node/hosted-plugin-remote.js:50:23)
    at Object.next (/home/theia/node_modules/@eclipse-che/theia-remote/lib/node/hosted-plugin-remote.js:31:53)
    at /home/theia/node_modules/@eclipse-che/theia-remote/lib/node/hosted-plugin-remote.js:25:71
    at new Promise (<anonymous>)
    at __awaiter (/home/theia/node_modules/@eclipse-che/theia-remote/lib/node/hosted-plugin-remote.js:21:12)
    at HostedPluginRemote.getExtraDeployedPluginIds (/home/theia/node_modules/@eclipse-che/theia-remote/lib/node/hosted-plugin-remote.js:230:16)
    at ServerPluginProxyRunner.getExtraDeployedPluginIds (/home/theia/node_modules/@eclipse-che/theia-remote/lib/node/server-plugin-proxy-runner.js:62:40)
root ERROR Failed to load plugins: Error: Request 'getDeployedPluginIds' failed
    at Proxy.<anonymous> (https://static.developers.redhat.com/che/theia_artifacts/theia.6c6f13cbd02928114839.js:1:1789599)
    at e.<anonymous> (https://static.developers.redhat.com/che/theia_artifacts/theia.6c6f13cbd02928114839.js:1:2465656)
    at https://static.developers.redhat.com/che/theia_artifacts/theia.6c6f13cbd02928114839.js:1:2461141
    at Object.next (https://static.developers.redhat.com/che/theia_artifacts/theia.6c6f13cbd02928114839.js:1:2461246)
    at https://static.developers.redhat.com/che/theia_artifacts/theia.6c6f13cbd02928114839.js:1:2460159
    at new Promise (<anonymous>)
    at a (https://static.developers.redhat.com/che/theia_artifacts/theia.6c6f13cbd02928114839.js:1:2459936)
    at e.syncPlugins (https://static.developers.redhat.com/che/theia_artifacts/theia.6c6f13cbd02928114839.js:1:2465371)
    at e.<anonymous> (https://static.developers.redhat.com/che/theia_artifacts/theia.6c6f13cbd02928114839.js:1:2464947)
    at https://static.developers.redhat.com/che/theia_artifacts/theia.6c6f13cbd02928114839.js:1:2461141
root WARN e.onStart is slow, took: 152.43499999996857 ms
root INFO [hosted-plugin: 48] PLUGIN_HOST(48) starting instance

l0rd · 2019-10-04T15:30:41Z

@vinokurig I have tested nightly and it's failing there as well so that should not be related to this PR.

musienko-maxim · 2019-10-04T16:11:05Z

I've checked this PR locally all steps from HappyPath scenario are passed.

l0rd · 2019-10-04T17:41:02Z

@musienko-maxim minishift or minikube?

che-bot · 2019-10-06T10:10:19Z

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

build details
logs and configs
"che-server" docker image: maxura/che-server:14767

che-bot · 2019-10-06T10:56:32Z

E2E tests of Eclipse Che Multiuser on OCP has been successful:

Build details
Test report
docker image: eclipseche/che-server:14767

dmytro-ndp · 2019-10-06T11:02:26Z

@l0rd:

@musienko-maxim minishift or minikube?

It was tested on minikube.
And E2E Happy path test had finnaly passed after fixup of test devfile #14767 (comment)

l0rd

LGTM I was able to test on both minikube and minishift. @vinokurig I would be glad if you could start working at #14775 as soon as you merge this one.

vinokurig added the area/editor/theia Issues related to the che-theia IDE of Che label Oct 3, 2019

vinokurig requested review from amisevsk, l0rd, metlos, nickboldt, rhopp and sleshchenko as code owners October 3, 2019 14:41

vinokurig requested a review from vparfonov October 3, 2019 14:41

che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/enhancement A feature request - must adhere to the feature request template. labels Oct 3, 2019

Generate a new SSH key if no keys are present while ssh mount

e9bfb83

Signed-off-by: Igor Vinokur <ivinokur@redhat.com>

vinokurig force-pushed the CHE-14411 branch from ccb84ce to e9bfb83 Compare October 4, 2019 05:36

vparfonov approved these changes Oct 4, 2019

View reviewed changes

eclipse-che deleted a comment from che-bot Oct 4, 2019

musienko-maxim self-requested a review October 4, 2019 16:11

musienko-maxim approved these changes Oct 4, 2019

View reviewed changes

Merge remote-tracking branch 'origin/master' into CHE-14411

1649a34

l0rd approved these changes Oct 6, 2019

View reviewed changes

amisevsk approved these changes Oct 7, 2019

View reviewed changes

vinokurig merged commit 4155919 into master Oct 7, 2019

vinokurig deleted the CHE-14411 branch October 7, 2019 05:38

davidwindell mentioned this pull request Oct 7, 2019

Unable to clone with SSH: unprotected private key file #14398

Closed

19 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generate a new SSH key if no keys are registered while ssh mount #14767

Generate a new SSH key if no keys are registered while ssh mount #14767

vinokurig commented Oct 3, 2019

che-bot commented Oct 3, 2019

che-bot commented Oct 3, 2019

dmytro-ndp commented Oct 3, 2019

che-bot commented Oct 3, 2019

dmytro-ndp commented Oct 3, 2019

che-bot commented Oct 3, 2019

che-bot commented Oct 4, 2019

vinokurig commented Oct 4, 2019

che-bot commented Oct 4, 2019

che-bot commented Oct 4, 2019

vinokurig commented Oct 4, 2019

che-bot commented Oct 4, 2019

che-bot commented Oct 4, 2019

dmytro-ndp commented Oct 4, 2019

l0rd commented Oct 4, 2019

l0rd commented Oct 4, 2019

musienko-maxim commented Oct 4, 2019

l0rd commented Oct 4, 2019

che-bot commented Oct 6, 2019 •

edited by dmytro-ndp

Loading

che-bot commented Oct 6, 2019

dmytro-ndp commented Oct 6, 2019

l0rd left a comment

Generate a new SSH key if no keys are registered while ssh mount #14767

Generate a new SSH key if no keys are registered while ssh mount #14767

Conversation

vinokurig commented Oct 3, 2019

What does this PR do?

What issues does this PR fix or reference?

Release Notes

Docs PR

che-bot commented Oct 3, 2019

che-bot commented Oct 3, 2019

dmytro-ndp commented Oct 3, 2019

che-bot commented Oct 3, 2019

dmytro-ndp commented Oct 3, 2019

che-bot commented Oct 3, 2019

che-bot commented Oct 4, 2019

vinokurig commented Oct 4, 2019

che-bot commented Oct 4, 2019

che-bot commented Oct 4, 2019

vinokurig commented Oct 4, 2019

che-bot commented Oct 4, 2019

che-bot commented Oct 4, 2019

dmytro-ndp commented Oct 4, 2019

l0rd commented Oct 4, 2019

l0rd commented Oct 4, 2019

musienko-maxim commented Oct 4, 2019

l0rd commented Oct 4, 2019

che-bot commented Oct 6, 2019 • edited by dmytro-ndp Loading

che-bot commented Oct 6, 2019

dmytro-ndp commented Oct 6, 2019

l0rd left a comment

Choose a reason for hiding this comment

che-bot commented Oct 6, 2019 •

edited by dmytro-ndp

Loading