Fix editor components alias attribute format to match plugins attribute format #14715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te format; Signed-off-by: Max Shaposhnik <mshaposh@redhat.com>
mshaposhnik
requested review from
l0rd,
metlos,
nickboldt,
rhopp and
sleshchenko
as code owners
mshaposhnik
requested review from
skabashnyuk
and removed request for
nickboldt,
l0rd and
rhopp
che-bot
added
kind/bug
sleshchenko
approved these changes
Sep 30, 2019
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
metlos
approved these changes
Sep 30, 2019
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
sparkoo
approved these changes
Sep 30, 2019
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes format of the
id=aliaseditor component attribute to match the same for plugin components.Fixes bug when the alias of editor component set via reference not reflected in the runtime machines.
What issues does this PR fix or reference?
Release Notes
N/A
Docs PR
N/A