Change grafana dashboards for number of workspaces/users to be graphs with axes #14588

tomgeorge · 2019-09-18T20:00:33Z

What does this PR do?

Changes the "Number of Users" and "Number of Workspaces" Grafana Panels to show axes, and add nice labels to the legend

What issues does this PR fix or reference?

Change grafana dashboards for number of workspaces/users to be graphs that show axes, legends

Testing

oc apply -f deploy/openshift/templates/monitoring/grafana-dashboards.yaml -f deploy/openshift/templates/monitoring/grafana-datasources.yaml
oc process -f deploy/openshift/templates/monitoring/che-monitoring.yaml | oc apply -f -
# ensure CHE_METRICS_ENABLED=true

Release Notes

Docs PR

che-bot · 2019-09-18T20:00:34Z

Can one of the admins verify this patch?

che-bot · 2019-09-18T20:00:34Z

Can one of the admins verify this patch?

ibuziuk · 2019-09-18T20:06:24Z

deploy/openshift/templates/monitoring/grafana-dashboards.yaml

+          "legend": {
+            "avg": false,
+            "current": false,
+            "max": false,


could we have it set to true

ibuziuk · 2019-09-18T20:06:32Z

deploy/openshift/templates/monitoring/grafana-dashboards.yaml

+            "avg": false,
+            "current": false,
+            "max": false,
+            "min": false,


could we have it set to true

ibuziuk · 2019-09-18T20:08:18Z

deploy/openshift/templates/monitoring/grafana-dashboards.yaml

+          "legend": {
+            "avg": false,
+            "current": false,
+            "max": false,


could we have it set to true

ibuziuk · 2019-09-18T20:08:33Z

deploy/openshift/templates/monitoring/grafana-dashboards.yaml

+            "avg": false,
+            "current": false,
+            "max": false,
+            "min": false,


could we have it set to true

skabashnyuk · 2019-09-19T05:53:32Z

May I suggest an alternative approach?

I would like to propose

leave area 1 as an indicator area. With values that are simple to read.
Like just numbers without graphs.
Move a total number of workspaces to workspace area - 2. Here we can make it as a graph with min, max, avg values
Make a user panel somewhere below. We can add total number of uses, later we can add online aka active users number.

ibuziuk · 2019-09-19T12:31:48Z

@skabashnyuk sounds like a good idea @tomgeorge wdyt ?

tomgeorge · 2019-09-19T12:42:20Z

I can make that change

tomgeorge · 2019-09-19T13:29:59Z

Pushed the suggested changes

cc @ibuziuk @skabashnyuk

skabashnyuk · 2019-09-19T13:31:37Z

Can you provide a screenshot of the result?

skabashnyuk · 2019-09-19T13:33:03Z

−415 lines removed. Are you sure I have the latest #14578 changes ?

tomgeorge · 2019-09-19T13:35:51Z

No looks like I messed that up. I need to fix this branch.

… that show axes, legends Signed-off-by: Tom George <tg82490@gmail.com>

Signed-off-by: Tom George <tg82490@gmail.com>

Moved # of workspaces graph to the workspaces row Moved # of users graph to a new Users row Signed-off-by: Tom George <tg82490@gmail.com>

tomgeorge · 2019-09-19T14:32:46Z

GH was showing only 2 commits in the PR view compared to master...tomgeorge:che-14155 which was showing 3 commits. Looks like the state got out of whack on the GH side. Changing the base branch to 7.0.x and back to master seems to show the correct diff. Sorry!

tomgeorge · 2019-09-19T14:33:29Z

General row

Workspaces row

Users row

edit: s/panel/row

ibuziuk · 2019-09-19T16:09:05Z

deploy/openshift/templates/monitoring/grafana-dashboards.yaml

@@ -3721,7 +3727,7 @@ data:
              "value": "null"
            }
          ],
-          "valueName": "current"
+          "valueName": "avg"


@tomgeorge so, currently the Number of Users / Number of Workspaces will show the average for the given timeframe? Not sure if it makes sense... I would opt for Current number of users & workspaces

Good catch, changed back to current.

Signed-off-by: Tom George <tg82490@gmail.com>

ibuziuk

LGTM
@skabashnyuk could you please provide code-owner review / approval ?

amisevsk

LGTM

skabashnyuk

Looks good to me.

skabashnyuk · 2019-09-24T06:45:27Z

deploy/openshift/templates/monitoring/grafana-dashboards.yaml

+          },
+          "yaxes": [
+            {
+              "format": "short",


"decimals": 0,
maybe it makes sense to add "decimals=0"

skabashnyuk · 2019-09-24T06:46:25Z

deploy/openshift/templates/monitoring/grafana-dashboards.yaml

+          },
+          "yaxes": [
+            {
+              "format": "short",


what about "decimals": 0, ?

Signed-off-by: Tom George <tg82490@gmail.com>

)

…zero precision Signed-off-by: Tom George <tg82490@gmail.com>

Signed-off-by: Tom George <tg82490@gmail.com>

tomgeorge · 2019-09-24T13:19:25Z

@skabashnyuk I changed the formatting of those panels to have zero precision

ibuziuk · 2019-09-25T07:47:39Z

ci-build

tomgeorge requested review from l0rd, metlos, nickboldt, rhopp and skabashnyuk as code owners September 18, 2019 20:00

che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/enhancement A feature request - must adhere to the feature request template. labels Sep 18, 2019

tomgeorge force-pushed the che-14155 branch from 6980a2e to bc23c7e Compare September 18, 2019 20:04

ibuziuk reviewed Sep 18, 2019

View reviewed changes

tomgeorge requested a review from ibuziuk September 19, 2019 00:50

tomgeorge force-pushed the che-14155 branch from b86528d to 11c92b0 Compare September 19, 2019 13:28

tomgeorge added 2 commits September 19, 2019 08:38

Change grafana dashboards for number of workspaces/users to be graphs…

2fd3689

… that show axes, legends Signed-off-by: Tom George <tg82490@gmail.com>

Add min/max/current to panels

8a57f2b

Signed-off-by: Tom George <tg82490@gmail.com>

tomgeorge force-pushed the che-14155 branch from 11c92b0 to 8a57f2b Compare September 19, 2019 13:40

Made # of users/# of workspaces singlestats in the General row again

fa888c6

Moved # of workspaces graph to the workspaces row Moved # of users graph to a new Users row Signed-off-by: Tom George <tg82490@gmail.com>

tomgeorge changed the base branch from master to 7.0.x September 19, 2019 14:30

tomgeorge requested review from amisevsk and ashumilova as code owners September 19, 2019 14:30

tomgeorge requested review from benoitf, dmytro-ndp, mshaposhnik, musienko-maxim, Ohrimenko1988, sleshchenko and vparfonov as code owners September 19, 2019 14:30

tomgeorge changed the base branch from 7.0.x to master September 19, 2019 14:30

ibuziuk reviewed Sep 19, 2019

View reviewed changes

Change back to current instead of average

68436e4

Signed-off-by: Tom George <tg82490@gmail.com>

tomgeorge requested a review from ibuziuk September 19, 2019 16:53

Change number of workspaces back to current

de64ad5

Signed-off-by: Tom George <tg82490@gmail.com>

ibuziuk approved these changes Sep 23, 2019

View reviewed changes

amisevsk approved these changes Sep 24, 2019

View reviewed changes

skabashnyuk approved these changes Sep 24, 2019

View reviewed changes

tomgeorge and others added 3 commits September 24, 2019 08:09

Merge branch 'master' of github.com:eclipse/che into che-14155

2619e03

Signed-off-by: Tom George <tg82490@gmail.com>

[Selenium] Adapt selenium tests from ocpoauth package (eclipse-che#14619

f36afab

)

format decimals for number of users and number of workspaces to have …

a19ab14

…zero precision Signed-off-by: Tom George <tg82490@gmail.com>

tomgeorge force-pushed the che-14155 branch from 0e5fdb3 to a19ab14 Compare September 24, 2019 13:15

Merge branch 'master' of github.com:eclipse/che into che-14155

f82a6f5

Signed-off-by: Tom George <tg82490@gmail.com>

tomgeorge force-pushed the che-14155 branch from 8417f65 to f82a6f5 Compare September 24, 2019 13:18

ibuziuk merged commit 053b2fd into eclipse-che:master Sep 25, 2019

tomgeorge deleted the che-14155 branch September 25, 2019 12:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change grafana dashboards for number of workspaces/users to be graphs with axes #14588

Change grafana dashboards for number of workspaces/users to be graphs with axes #14588

tomgeorge commented Sep 18, 2019

che-bot commented Sep 18, 2019

che-bot commented Sep 18, 2019

ibuziuk Sep 18, 2019

tomgeorge Sep 18, 2019

ibuziuk Sep 18, 2019

tomgeorge Sep 18, 2019

ibuziuk Sep 18, 2019

tomgeorge Sep 18, 2019

ibuziuk Sep 18, 2019

tomgeorge Sep 18, 2019

skabashnyuk commented Sep 19, 2019 •

edited

Loading

ibuziuk commented Sep 19, 2019

tomgeorge commented Sep 19, 2019

tomgeorge commented Sep 19, 2019

skabashnyuk commented Sep 19, 2019

skabashnyuk commented Sep 19, 2019

tomgeorge commented Sep 19, 2019

tomgeorge commented Sep 19, 2019

tomgeorge commented Sep 19, 2019 •

edited

Loading

ibuziuk Sep 19, 2019

tomgeorge Sep 19, 2019

ibuziuk left a comment

amisevsk left a comment

skabashnyuk left a comment •

edited

Loading

skabashnyuk Sep 24, 2019

skabashnyuk Sep 24, 2019

tomgeorge commented Sep 24, 2019 •

edited

Loading

ibuziuk commented Sep 25, 2019

Change grafana dashboards for number of workspaces/users to be graphs with axes #14588

Change grafana dashboards for number of workspaces/users to be graphs with axes #14588

Conversation

tomgeorge commented Sep 18, 2019

What does this PR do?

What issues does this PR fix or reference?

Testing

Release Notes

Docs PR

che-bot commented Sep 18, 2019

che-bot commented Sep 18, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

skabashnyuk commented Sep 19, 2019 • edited Loading

ibuziuk commented Sep 19, 2019

tomgeorge commented Sep 19, 2019

tomgeorge commented Sep 19, 2019

skabashnyuk commented Sep 19, 2019

skabashnyuk commented Sep 19, 2019

tomgeorge commented Sep 19, 2019

tomgeorge commented Sep 19, 2019

tomgeorge commented Sep 19, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ibuziuk left a comment

Choose a reason for hiding this comment

amisevsk left a comment

Choose a reason for hiding this comment

skabashnyuk left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tomgeorge commented Sep 24, 2019 • edited Loading

ibuziuk commented Sep 25, 2019

skabashnyuk commented Sep 19, 2019 •

edited

Loading

tomgeorge commented Sep 19, 2019 •

edited

Loading

skabashnyuk left a comment •

edited

Loading

tomgeorge commented Sep 24, 2019 •

edited

Loading