Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new Tomcat metrics dashboard in Grafana #14578

Merged
merged 3 commits into from
Sep 19, 2019
Merged

Add new Tomcat metrics dashboard in Grafana #14578

merged 3 commits into from
Sep 19, 2019

Conversation

mkuznyetsov
Copy link
Contributor

@mkuznyetsov mkuznyetsov commented Sep 18, 2019 •
edited
Loading

What does this PR do?

Add new tomcat dashboard with session metrics:
Screenshot from 2019-09-18 18-10-24

What issues does this PR fix or reference?

Release Notes

Docs PR

@che-bot che-bot added kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Sep 18, 2019
@che-bot
Copy link
Contributor

che-bot commented Sep 18, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14578

@che-bot
Copy link
Contributor

che-bot commented Sep 18, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@skabashnyuk
Copy link
Contributor

Can you add some screenshots?

@che-bot
Copy link
Contributor

che-bot commented Sep 18, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14578

@che-bot
Copy link
Contributor

che-bot commented Sep 18, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

skabashnyuk
skabashnyuk approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@skabashnyuk skabashnyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall look good

deploy/openshift/templates/monitoring/grafana-dashboards.yaml Outdated Show resolved Hide resolved
@che-bot
Copy link
Contributor

che-bot commented Sep 19, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14578

@mkuznyetsov mkuznyetsov merged commit 4ba2ec7 into master Sep 19, 2019
@mkuznyetsov mkuznyetsov deleted the tomcat-metrics branch September 19, 2019 13:08
@che-bot
Copy link
Contributor

che-bot commented Sep 19, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 19, 2019
@che-bot che-bot added this to the 7.2.0 milestone Sep 19, 2019
@skabashnyuk skabashnyuk mentioned this pull request Sep 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skabashnyuk skabashnyuk skabashnyuk approved these changes

@l0rd l0rd Awaiting requested review from l0rd

@metlos metlos Awaiting requested review from metlos

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

Assignees
No one assigned
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Milestone
7.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mkuznyetsov @che-bot @skabashnyuk