Remove WsAgent specific classes from che-core-workspace-api #14528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleshchenko
requested review from
amisevsk,
dmytro-ndp,
l0rd,
metlos,
mshaposhnik,
musienko-maxim,
nickboldt,
Ohrimenko1988,
rhopp and
skabashnyuk
as code owners
che-bot
added
status/code-review
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
amisevsk
approved these changes
Sep 12, 2019
skabashnyuk
approved these changes
Sep 13, 2019
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
sleshchenko
force-pushed
the
deleteWsAgentSpecifiClasses
branch
from
1bf7d49
to
3ff22ee
Compare
|
Rebased against master to get fresh needed changes for CI tests |
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
|
ci-test |
|
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
che-bot
removed
the
status/code-review
musienko-maxim
pushed a commit
that referenced
this pull request
Sep 17, 2019
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
musienko-maxim
pushed a commit
that referenced
this pull request
Sep 17, 2019
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes WsAgent (from Che 6) specific classes from workspace-api to prevent appering the error reported in the issue, and after that - workspace should be recovered fine.
It does not really fix a cause of issue - that it's possible to create a workspace with 2 wsagents pods, but it does not make sense to invest time there since we don't support Che 6 workspace anymore.
What issues does this PR fix or reference?
Fixes #14526
Release Notes
N/A
Docs PR
N/A