Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[E2E] Parametrize docker to set test suite #14507

Merged
merged 1 commit into from
Sep 12, 2019
Merged

[E2E] Parametrize docker to set test suite #14507

merged 1 commit into from
Sep 12, 2019

Conversation

Katka92
Copy link
Contributor

@Katka92 Katka92 commented Sep 11, 2019 •
edited by dmytro-ndp
Loading

What does this PR do?

Add TEST_SUITE variable to docker run command. Now user can set the command from package.json that specifies the suite that will be run.
Add example of TEST_SUITE usage to README.md.

Is related to #14027

@che-bot
Copy link
Contributor

che-bot commented Sep 11, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@che-bot che-bot added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 11, 2019
@che-bot
Copy link
Contributor

che-bot commented Sep 11, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14507

@Katka92
Copy link
Contributor Author

Katka92 commented Sep 11, 2019

ci-test

@che-bot
Copy link
Contributor

che-bot commented Sep 11, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@Katka92
Copy link
Contributor Author

Katka92 commented Sep 11, 2019

ci-build

dmytro-ndp
dmytro-ndp approved these changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dmytro-ndp dmytro-ndp merged commit 2431795 into eclipse-che:master Sep 12, 2019
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 12, 2019
@che-bot che-bot added this to the 7.2.0 milestone Sep 12, 2019
@che-bot
Copy link
Contributor

che-bot commented Sep 12, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14507

@che-bot
Copy link
Contributor

che-bot commented Sep 12, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@Katka92 Katka92 mentioned this pull request Sep 16, 2019
Closed
@Katka92 Katka92 deleted the e2e_parameterize_docker branch March 3, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@benoitf benoitf Awaiting requested review from benoitf

@l0rd l0rd Awaiting requested review from l0rd

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim

@nickboldt nickboldt Awaiting requested review from nickboldt

@Ohrimenko1988 Ohrimenko1988 Awaiting requested review from Ohrimenko1988

@rhopp rhopp Awaiting requested review from rhopp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Katka92 @che-bot @dmytro-ndp