Don't blow up on missing path transform configuration #14339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't blow up on missing path transform configuration. Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
metlos
requested review from
amisevsk,
l0rd,
nickboldt,
rhopp and
sleshchenko
as code owners
che-bot
added
the
status/code-review
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
sleshchenko
approved these changes
Aug 27, 2019
|
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
amisevsk
approved these changes
Aug 27, 2019
amisevsk
reviewed
Aug 27, 2019
| @@ -52,6 +52,9 @@ public IngressPathTransformInverter( | |||
| * @return the regex that essentially reverts the effect of the path transformation | |||
| */ | |||
| private static Pattern extractPathFromFmt(String pathTransformFmt) { | |||
| if (pathTransformFmt == null) { | |||
| return Pattern.compile("^(.*)$"); | |||
There was a problem hiding this comment.
What about using PATH_TRANSFORM_PATH_CATCH here? It's used in the null check in ExternalServerExposer.
There was a problem hiding this comment.
This is basically a short hand for what the result would be if PATH_TRANSFORM_PATH_CATCH was the input to this method. I didn't want to do the processing when the result is directly known...
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
$TITLEWhat issues does this PR fix or reference?
#14336