Avoid using DtoImpls directly #14320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
sleshchenko
requested review from
amisevsk,
l0rd,
metlos,
mshaposhnik,
nickboldt and
rhopp
as code owners
|
ci-build |
che-bot
added
status/code-review
sleshchenko
added
kind/task
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
skabashnyuk
approved these changes
Aug 23, 2019
|
ci-test |
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Avoid using DtoImpls directly.
It also enables tests in
IdentityProviderConfigBuilderTestthat did not have@Testannotations, probably by mistake because they pass just fine.What issues does this PR fix or reference?
#14318
Release Notes
N/A
Docs PR
N/A