Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential security vulnerabilities #14313

Merged
merged 5 commits into from
Sep 16, 2019
Merged

Fix potential security vulnerabilities #14313

merged 5 commits into from
Sep 16, 2019

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

Upgrade dependencies:

  • lodash to 4.17.15
  • angularJS and related modules to 1.6.10

What issues does this PR fix or reference?

#13924

Signed-off-by: Oleksii Kurinnyi okurinny@redhat.com

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Aug 22, 2019
@monaka monaka mentioned this pull request Aug 29, 2019
Closed
@akurinnoy akurinnoy force-pushed the upgrade-dependencies branch 2 times, most recently from c15c8fe to 015365c Compare September 9, 2019 14:02
@eclipse-che eclipse-che deleted a comment from che-bot Sep 10, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 10, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 10, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 10, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 10, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 10, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 10, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 10, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 10, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 10, 2019
@akurinnoy akurinnoy force-pushed the upgrade-dependencies branch 2 times, most recently from c74e639 to 5c038e9 Compare September 10, 2019 18:15
@eclipse-che eclipse-che deleted a comment from che-bot Sep 11, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 11, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 11, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 11, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 11, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 11, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 11, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 11, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 11, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 11, 2019
@SkorikSergey
Copy link
Contributor

ci-test

@che-bot
Copy link
Contributor

che-bot commented Sep 11, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@che-bot
Copy link
Contributor

che-bot commented Sep 13, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Sep 13, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@akurinnoy
upgrade dependencies
757a82f 
lodash to 4.17.15
angularJS to v1.6.10

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@akurinnoy
fix unit tests
5ab2bdc 
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@akurinnoy
fix tests for Che Multiuser
4144449 
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@akurinnoy
restore dialogs controllers initialization
966b7ed
@eclipse-che eclipse-che deleted a comment from che-bot Sep 13, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 13, 2019
@che-bot
Copy link
Contributor

che-bot commented Sep 13, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@eclipse-che eclipse-che deleted a comment from che-bot Sep 13, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 13, 2019
@che-bot
Copy link
Contributor

che-bot commented Sep 13, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@SkorikSergey
Copy link
Contributor

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Sep 16, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14313

@che-bot
Copy link
Contributor

che-bot commented Sep 16, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14313

@che-bot
Copy link
Contributor

che-bot commented Sep 16, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@akurinnoy akurinnoy merged commit 1834467 into master Sep 16, 2019
@akurinnoy akurinnoy deleted the upgrade-dependencies branch September 16, 2019 13:16
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 16, 2019
@che-bot che-bot added this to the 7.2.0 milestone Sep 16, 2019
musienko-maxim pushed a commit that referenced this pull request Sep 17, 2019
@akurinnoy @musienko-maxim
Fix potential security vulnerabilities (#14313)
30ffb46 
* upgrade dependencies

lodash to 4.17.15
angularJS to v1.6.10

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* fix unit tests

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* fix tests for Che Multiuser

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* restore dialogs controllers initialization

* fixup! fix tests for Che Multiuser
musienko-maxim pushed a commit that referenced this pull request Sep 17, 2019
@akurinnoy @musienko-maxim
Fix potential security vulnerabilities (#14313)
6be1a74 
* upgrade dependencies

lodash to 4.17.15
angularJS to v1.6.10

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* fix unit tests

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* fix tests for Che Multiuser

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* restore dialogs controllers initialization

* fixup! fix tests for Che Multiuser
skabashnyuk pushed a commit that referenced this pull request Jan 3, 2020
@akurinnoy
Fix potential security vulnerabilities (#14313)
f387e1a 
* upgrade dependencies

lodash to 4.17.15
angularJS to v1.6.10

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* fix unit tests

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* fix tests for Che Multiuser

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* restore dialogs controllers initialization

* fixup! fix tests for Che Multiuser
skabashnyuk pushed a commit to skabashnyuk/che that referenced this pull request Mar 11, 2020
@akurinnoy
Fix potential security vulnerabilities (eclipse-che#14313)
bb80dce 
* upgrade dependencies

lodash to 4.17.15
angularJS to v1.6.10

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* fix unit tests

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* fix tests for Che Multiuser

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* restore dialogs controllers initialization

* fixup! fix tests for Che Multiuser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olexii4 olexii4 olexii4 approved these changes

@SkorikSergey SkorikSergey SkorikSergey approved these changes

@mmorhun mmorhun mmorhun approved these changes

@dmytro-ndp dmytro-ndp Awaiting requested review from dmytro-ndp

@l0rd l0rd Awaiting requested review from l0rd

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim

@nickboldt nickboldt Awaiting requested review from nickboldt

@Ohrimenko1988 Ohrimenko1988 Awaiting requested review from Ohrimenko1988

@rhopp rhopp Awaiting requested review from rhopp

@vparfonov vparfonov Awaiting requested review from vparfonov

@benoitf benoitf Awaiting requested review from benoitf

Assignees

@akurinnoy akurinnoy

Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
7.2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@akurinnoy @SkorikSergey @che-bot @benoitf @olexii4 @mmorhun