factory will always use devfile generateName

[sparkoo]

Signed-off-by: Michal Vala mvala@redhat.com

What does this PR do?

Fixes possible workspace name collision when using factory with devfile. It takes generateName with precedence and converts name into generateName, when only name is defined. With this, we should always create uniquely named workspace that will have 5 random characters suffix.

• When devfile has only name, it use it as generateName -> nameYYYYY
• When devfile has only generateName, it uses that -> generateNameYYYY
• When devfile has both name and generateName, it uses generateName -> generateNameYYYY
  (Y is random [0-9a-z] characted)

I've choosen to take generateName over name here, because there is higher chance that it would generate nicer name. If you have other opinion, please comment.

What issues does this PR fix or reference?

#13683

Release Notes

Docs PR

[sleshchenko]

Seems it should be modified as well https://github.com/eclipse/che/blob/8d3cc8054a4ff13e5405400cbaf7221243399b33/wsmaster/che-core-api-factory/src/main/java/org/eclipse/che/api/factory/server/urlfactory/URLFactoryBuilder.java#L154

[metlos]

Nice way of fixing #13683!

[sparkoo]

Seems it should be modified as well

https://github.com/eclipse/che/blob/8d3cc8054a4ff13e5405400cbaf7221243399b33/wsmaster/che-core-api-factory/src/main/java/org/eclipse/che/api/factory/server/urlfactory/URLFactoryBuilder.java#L154

It doesn't have to. The devfile naming is "fixed" later in the process. If you think it would be better, I'll modify it.

[che-bot]

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

• build details
• "che-server" docker image: maxura/che-server:14311

[sleshchenko]

It doesn't have to. The devfile naming is "fixed" later in the process.

I stared like a few minutes and did not manage to find where it will be fixed later.
BTW I think it would be more straightforward to set generateName right there instead of relying on name to generateName moving later. Or do you think there are props of moving these fields later?

[sparkoo]

It doesn't have to. The devfile naming is "fixed" later in the process.

I stared like a few minutes and did not manage to find where it will be fixed later.
BTW I think it would be more straightforward to set generateName right there instead of relying on name to generateName moving later. Or do you think there are props of moving these fields later?

you're right, it's not fixed later. I've missed that, twice :) Thanks for the catch. fixed

[che-bot]

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

• build details
• "che-server" docker image: maxura/che-server:14311

[che-bot]

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14311
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

[che-bot]

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14311
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

[sleshchenko]

LGTM

[dmytro-ndp]

ci-test