-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the jwt-proxy memory as a part of stack's globalMemoryLimit #14270
Conversation
ci-test |
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
ci-test |
crw-ci-test |
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
Signed-off-by: Oleksii Orel <oorel@redhat.com>
ci-test |
crw-ci-test |
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/2032//Selenium_20tests_20report/) doesn't show any regression against this Pull request. |
if (!memoryLimit) { | ||
return -1; | ||
} | ||
const regExpExecArray = /^([0-9]+)([a-zA-Z]{1,3})$/.exec(memoryLimit); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to improve regexp using values from enum MemoryUnit, but up to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I check the MemoryUnit in this place of code
https://github.com/eclipse/che/pull/14270/files/35a5ea6771cc28eee7506acaf132e17cc93bf51a#diff-6296915bbb52eb6ee7111f8e2fd1e2feR126
In this case, it will be simpler to change something - just change the units enum in the head of the file
https://github.com/eclipse/che/pull/14270/files/35a5ea6771cc28eee7506acaf132e17cc93bf51a#diff-6296915bbb52eb6ee7111f8e2fd1e2feR24
Signed-off-by: Oleksii Orel oorel@redhat.com
What does this PR do?
Add the 'jwt-proxy' memory as a part of stack's globalMemoryLimit for all stack lists for UD.
What issues does this PR fix or reference?
#14001