Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Use next version for default plugins" #14249

Merged
merged 3 commits into from
Aug 15, 2019
Merged

Revert "Use next version for default plugins" #14249

merged 3 commits into from
Aug 15, 2019

Conversation

vparfonov
Copy link
Contributor

Reverts #14247

@vparfonov
Use taged version for plugins
3214f34 
Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
@che-bot che-bot added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 15, 2019
@rhopp
Copy link
Contributor

rhopp commented Aug 15, 2019

We will implement temporary solution for e2e tests to unblock PR check, while still having che-theia:next in master.
(e2e tests will still use che-theia:7.0.0 until we adapt tests to che-theia:next).
This will render this PR as unnecessary.

@che-bot
Copy link
Contributor

che-bot commented Aug 15, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@vparfonov
set 7.0.0 version for plugin registry
33d0269 
Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Aug 15, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

nickboldt
nickboldt reviewed Aug 15, 2019
View reviewed changes
Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, if the PR check passes. Waiting on https://codeready-workspaces-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/Single-Che-PR-check-E2E-Happy-path-tests-against-k8s-on-codenvy-slave9/99/console to get a slave on which it can run...

@rhopp rhopp mentioned this pull request Aug 15, 2019
Closed
@che-bot
Copy link
Contributor

che-bot commented Aug 15, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14249

@rhopp rhopp merged commit e08d24c into master Aug 15, 2019
@rhopp rhopp mentioned this pull request Aug 15, 2019
Closed
@che-bot che-bot added this to the 7.1.0 milestone Aug 15, 2019
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 15, 2019
@vparfonov vparfonov deleted the revert-14247-useNextVers4plugins branch August 16, 2019 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickboldt nickboldt nickboldt left review comments

@rhopp rhopp rhopp approved these changes

@ibuziuk ibuziuk Awaiting requested review from ibuziuk

@l0rd l0rd Awaiting requested review from l0rd

@sleshchenko sleshchenko Awaiting requested review from sleshchenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@vparfonov @rhopp @che-bot @nickboldt