Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workspace-loader flow #14222

Merged
merged 1 commit into from
Aug 16, 2019
Merged

Add workspace-loader flow #14222

merged 1 commit into from
Aug 16, 2019

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Aug 14, 2019 •
edited
Loading

Covers Workspace Loader section of #14126

Signed-off-by: Oleksii oorel@redhat.com

@che-bot che-bot added kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Aug 14, 2019
@che-bot
Copy link
Contributor

che-bot commented Aug 14, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14222

@olexii4 olexii4 marked this pull request as ready for review August 14, 2019 11:55
@che-bot
Copy link
Contributor

che-bot commented Aug 14, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14222

@olexii4 olexii4 changed the title add workspace-loader flow for code contribution add workspace-loader flow Aug 14, 2019
@akurinnoy akurinnoy self-requested a review August 14, 2019 12:40
@che-bot
Copy link
Contributor

che-bot commented Aug 14, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14222

@che-bot
Copy link
Contributor

che-bot commented Aug 14, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14222

mmorhun
mmorhun reviewed Aug 14, 2019
View reviewed changes
Copy link
Contributor

@mmorhun mmorhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving some suggestions...

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
AndrienkoAleksandr
AndrienkoAleksandr reviewed Aug 14, 2019
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@che-bot
Copy link
Contributor

che-bot commented Aug 14, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

AndrienkoAleksandr
AndrienkoAleksandr reviewed Aug 14, 2019
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
AndrienkoAleksandr
AndrienkoAleksandr reviewed Aug 14, 2019
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@che-bot
Copy link
Contributor

che-bot commented Aug 14, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14222

@che-bot
Copy link
Contributor

che-bot commented Aug 14, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14222

@che-bot
Copy link
Contributor

che-bot commented Aug 14, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14222

@che-bot
Copy link
Contributor

che-bot commented Aug 14, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14222

@che-bot
Copy link
Contributor

che-bot commented Aug 14, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14222

@che-bot
Copy link
Contributor

che-bot commented Aug 14, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14222

@olexii4 olexii4 changed the title add workspace-loader flow Add workspace-loader flow Aug 15, 2019
@che-bot
Copy link
Contributor

che-bot commented Aug 15, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@olexii4
add workspace loader flow for code contribution
ed8717d 
Signed-off-by: Oleksii <oorel@redhat.com>
mmorhun
mmorhun approved these changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@mmorhun mmorhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@che-bot
Copy link
Contributor

che-bot commented Aug 15, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14222

@olexii4 olexii4 merged commit 09291a4 into master Aug 16, 2019
@olexii4 olexii4 deleted the CHE-14126 branch August 16, 2019 09:01
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 16, 2019
@che-bot che-bot added this to the 7.1.0 milestone Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vparfonov vparfonov vparfonov approved these changes

@AndrienkoAleksandr AndrienkoAleksandr AndrienkoAleksandr approved these changes

@mmorhun mmorhun mmorhun approved these changes

@akurinnoy akurinnoy akurinnoy approved these changes

@evidolob evidolob Awaiting requested review from evidolob

@sunix sunix Awaiting requested review from sunix

@l0rd l0rd Awaiting requested review from l0rd

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

Assignees
No one assigned
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@olexii4 @che-bot @vparfonov @AndrienkoAleksandr @mmorhun @akurinnoy