Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS SELENIUM] Fix the #13865 issue (Happy Path test is sometimes failing on "Error highlighting" step) #13987

Merged
merged 7 commits into from
Jul 24, 2019

Conversation

Ohrimenko1988
Copy link
Contributor

What does this PR do?

Fix the #13865 issue (Happy Path test is sometimes failing on "Error highlighting" step)

What issues does this PR fix or reference?

Issue: #13865

Release Notes

Docs PR

Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988 Ohrimenko1988 added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. team/che-qe labels Jul 24, 2019
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
Copy link
Contributor

@rhopp rhopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment. Otherwise looking ok.

await editor.waitErrorInLine(30);
await editor.performKeyCombination(javaFileName, Key.chord(Key.CONTROL, 'z'));
await editor.performKeyCombination(javaFileName, Key.chord(Key.BACK_SPACE, Key.BACK_SPACE, Key.BACK_SPACE, Key.BACK_SPACE, Key.BACK_SPACE));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't Ctrl+Backspace be nicer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about the stability of this approach (key combinations)

@Ohrimenko1988 Ohrimenko1988 merged commit a35bd99 into master Jul 24, 2019
@Ohrimenko1988 Ohrimenko1988 deleted the selen-fix-highlighting branch July 24, 2019 12:16
@Ohrimenko1988 Ohrimenko1988 removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants