Stabilize part for waiting Dashboard in WorkspaceCreationAndLsInitialization test #13850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musienko-maxim
requested review from
l0rd,
nickboldt,
Ohrimenko1988 and
rhopp
as code owners
rhopp
reviewed
Jul 15, 2019
| @@ -49,8 +49,9 @@ export class Dashboard { | |||
| } | |||
|
|
|||
| async openDashboard(timeout: number = TestConstants.TS_SELENIUM_LOAD_PAGE_TIMEOUT) { | |||
There was a problem hiding this comment.
Timeout parameter is not used in this method...
rhopp
approved these changes
Jul 15, 2019
|
I've approved the PR, but let's wait for the PR check to finish before merging... |
|
ci-build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improve openDashboard method in the Dashboard page object. Before the
driverHelper.navigateTo(TestConstants.TS_SELENIUM_BASE_URL);method compareTestConstants.TS_SELENIUM_BASE_URLand url from dashboard. But actually this url's can be not equal. Because after consuming theTestConstants.TS_SELENIUM_BASE_URLdashboard adddashboard/#/suffix to the TS_SELENIUM_BASE_URL. The reason what the test passed earlier - looks like Webdriver could catch Dashboar url before redirection and urls matched.This PR fix this problem.