Remove Diagnostics widget on UD #13815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
akurinnoy
added
kind/bug
ashumilova
approved these changes
Jul 11, 2019
|
ci-test |
benoitf
approved these changes
Jul 11, 2019
rhopp
approved these changes
Jul 11, 2019
|
@SkorikSergey @artaleks9 @dmytro-ndp Was this covered by selenium tests? If so, we need to delete/disable them too... |
|
@rhopp : we don't have dedicated e2e tests to check Diagnostics tool. |
l0rd
approved these changes
Jul 11, 2019
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
|
Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/1896//Selenium_20tests_20report/) doesn't show any regression against this Pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Oleksii Kurinnyi okurinny@redhat.com
What does this PR do?
This PR removes Diagnostics directive and link to Diagnostics page in Dashboard footer.
What issues does this PR fix or reference?
fix #13525