Update the use of Machines in Che #13808
Merged
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
skabashnyuk
requested review from
amisevsk,
l0rd,
metlos,
mshaposhnik,
nickboldt,
rhopp and
sleshchenko
as code owners
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
|
ci-test |
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
|
@eclipse/eclipse-che-qa can you take a look at test results? |
l0rd
reviewed
Jul 10, 2019
.../che/workspace/infrastructure/kubernetes/wsplugins/KubernetesBrokerInitContainerApplier.java
Outdated
Show resolved
Hide resolved
l0rd
reviewed
Jul 10, 2019
...-core-api-workspace/src/main/java/org/eclipse/che/api/workspace/server/hc/ServerChecker.java
Outdated
Show resolved
Hide resolved
|
#13703 is set to milestone 7.1... Sooo -1 for merging? |
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
|
@rhopp I've asked for clarification #13703 (comment) |
|
@l0rd @rhopp @mshaposhnik can you approve this pr? |
benoitf
approved these changes
Jul 11, 2019
l0rd
approved these changes
Jul 11, 2019
rhopp
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As discussed here #13703 Machine terminology is deprecated and should be updated. This pr replaces usage of
machineword with appropriate analog in some exceptions that might be exposed to end user.What issues does this PR fix or reference?
#13703
Release Notes
n/a
Docs PR
n/a