Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dashboard dependencies #13571

Merged
merged 2 commits into from
Jun 20, 2019
Merged

Upgrade dashboard dependencies #13571

merged 2 commits into from
Jun 20, 2019
+14 −14

Conversation

evidolob
Copy link
Contributor

What does this PR do?

Upgrades jquery to 3.4.0 and js-yaml to 3.13.1 to fix CVE warnings

@evidolob
Upgrade dashboard dependencies
93271bc 
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@evidolob evidolob requested a review from olexii4 June 19, 2019 07:20
@danidoedel
Copy link

@evidolob Is there a reason why you don't use jQuery 3.4.1?

@evidolob
Copy link
Contributor Author

evidolob commented Jun 19, 2019 •
edited
Loading

There are no particular reason to have 3.4.0, I just use suggested version
@danidoedel Are you suggest to use 3.4.1 ?

@evidolob
Copy link
Contributor Author

ci-test

@danidoedel
Copy link

@evidolob 3.4.1 is a bug fix release and I think it's always nice to have these bugs fixed in my opinion. It's up to you of course, I was just wondering.

@che-bot
Copy link
Contributor

che-bot commented Jun 19, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13571
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@evidolob
Set jquery version to '3.4.1'
febed08 
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@evidolob
Copy link
Contributor Author

ci-test

1 similar comment
@musienko-maxim
Copy link
Contributor

ci-test

@che-bot
Copy link
Contributor

che-bot commented Jun 19, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13571
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@musienko-maxim musienko-maxim self-requested a review June 20, 2019 07:30
@evidolob evidolob merged commit f9333f0 into master Jun 20, 2019
@evidolob evidolob deleted the fix-dashboard-cve branch June 20, 2019 07:34
@monaka monaka mentioned this pull request Jun 20, 2019
Closed
@che-bot che-bot added this to the 7.0.0 milestone Jun 27, 2019
skabashnyuk pushed a commit that referenced this pull request Jan 3, 2020
@evidolob
Upgrade dashboard dependencies (#13571)
ce84f35 
* Upgrade dashboard dependencies

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashumilova ashumilova ashumilova approved these changes

@musienko-maxim musienko-maxim musienko-maxim approved these changes

@olexii4 olexii4 Awaiting requested review from olexii4

@benoitf benoitf Awaiting requested review from benoitf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@evidolob @danidoedel @che-bot @musienko-maxim @ashumilova