Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow registry passwords longer than 128 chars #13569

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Allow registry passwords longer than 128 chars #13569

merged 1 commit into from
Jul 11, 2019

Conversation

johnmcollier
Copy link
Contributor

@johnmcollier johnmcollier commented Jun 19, 2019 •
edited
Loading

What does this PR do?

This PR allows users to specify passwords for docker registry credentials that are longer than 128 characters. Myself and some other team members have access to docker registries that use 128 characters and longer tokens for authentication, and Che was not allowing us to specify the credentials for the registry.

I've verified this change with both short and long tokens, including an 856 service account token used for pushing to an internal OpenShift registry

What issues does this PR fix or reference?

#5678

Release Notes

Allow registry passwords longer than 128 chars

@johnmcollier
Allow registry passwords longer than 128 chars
fcffa3b 
Signed-off-by: John Collier <John.J.Collier@ibm.com>
@che-bot
Copy link
Contributor

che-bot commented Jun 19, 2019

Can one of the admins verify this patch?

2 similar comments
@che-bot
Copy link
Contributor

che-bot commented Jun 19, 2019

Can one of the admins verify this patch?

@che-bot
Copy link
Contributor

che-bot commented Jun 19, 2019

Can one of the admins verify this patch?

@musienko-maxim
Copy link
Contributor

Can one of the admins verify this PR?

@benoitf
Copy link
Contributor

benoitf commented Jun 19, 2019

ci-build

@benoitf
Copy link
Contributor

benoitf commented Jun 19, 2019

ci-test

@che-bot
Copy link
Contributor

che-bot commented Jun 19, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13569
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/enhancement A feature request - must adhere to the feature request template. labels Jun 27, 2019
@johnmcollier
Copy link
Contributor Author

Is this PR good to be merged now?

@monaka
Copy link
Member

monaka commented Jul 9, 2019

@l0rd Can we merge this PR now? Or it's better to merge after released 7.0.0?

@l0rd
Copy link
Contributor

l0rd commented Jul 11, 2019

Considered the size of this PR and that it has been created before the code freeze I would be +1 to merge it now. @rhopp any concern?

@rhopp
Copy link
Contributor

rhopp commented Jul 11, 2019

+1 to merge.

@ashumilova ashumilova merged commit 7a323a6 into eclipse-che:master Jul 11, 2019
@che-bot
Copy link
Contributor

che-bot commented Jul 11, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13569
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@azatsarynnyy azatsarynnyy mentioned this pull request Feb 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@ashumilova ashumilova ashumilova approved these changes

Assignees
No one assigned
Labels
kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@johnmcollier @che-bot @musienko-maxim @benoitf @monaka @l0rd @rhopp @ashumilova