-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preferences for chePlugin components in Devfile #13341
Conversation
972aecf
to
d01d628
Compare
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments but otherwise good!
wsmaster/che-core-api-devfile/src/main/resources/schema/devfile.json
Outdated
Show resolved
Hide resolved
...core-api-model/src/main/java/org/eclipse/che/api/core/model/workspace/devfile/Component.java
Outdated
Show resolved
Hide resolved
Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/1801//Selenium_20tests_20report/) doesn't show any regression against this Pull Request. |
ae8983a
to
123ef3b
Compare
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
123ef3b
to
61710d9
Compare
Rebased onto master branch without any changes in PR |
ci-build |
What does this PR do?
This PR adds preferences for chePlugin components in Devfile.
As an example of Devfile where this functionality is used:
Devfile with configured typesctipt plugin
The same feature can be used with workspace config,
plugin.{PLUGIN_PUBLISHER}/{PLUGIN_NAME}.preference.{PREFERENCE_NAME}
workspace config attribute is used.Workspace config with configured plugin
There is a docker image
sleshchenko/che-server:plugin-prefs
that contains PR's changes. It may be used for testing.What issues does this PR fix or reference?
#12992
Release Notes
Added an ability to specify preferences for plugins in Devfile and Workspace Config.
Docs PR
Docs changes are included in the PR