Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for full build #20

Merged
merged 35 commits into from
Mar 13, 2024
Merged

Adding support for full build #20

merged 35 commits into from
Mar 13, 2024

Conversation

MelamudMichael
Copy link
Contributor

@MelamudMichael MelamudMichael commented Mar 10, 2024 •
edited
Loading

  1. Added support for full build
  2. Added template for unit-tests

MelamudMichael and others added 30 commits February 29, 2024 12:11
@MelamudMichael
Update README.md
40ef4bd
@MelamudMichael
Delete samples directory
22a9728
@MelamudMichael
Merge branch 'eclipse-uprotocol:main' into main
dd0e27d
@MelamudMichael
Merge branch 'eclipse-uprotocol:main' into main
c4fbf18
@MelamudMichael
enabling full build
783f9f0
@MelamudMichael
Update CMakeLists.txt
39fecbe
@MelamudMichael
fixing compilation
8ab3cf3
@MelamudMichael
fixing compilation
c5aa5c8
@MelamudMichael
updating version
9c08214
@MelamudMichael
Update conanfile.py
94779f7
@MelamudMichael
Update ci.yml
238b3e3
@MelamudMichael
Delete conaninfo directory
8d7a232
@MelamudMichael
Update ci.yml
6e24e1f
@MelamudMichael
Update conanfile.py
fd385a6
@MelamudMichael
Update ci.yml
72ce57b
@MelamudMichael
Update conanfile.py
bc234f0
@MelamudMichael
Update ci.yml
67e535e
@MelamudMichael
Update CMakeLists.txt
a76d23c
@MelamudMichael
Update CMakeLists.txt
2eb7752
@MelamudMichael
Update CMakeLists.txt
2950ae7
@MelamudMichael
Update CMakeLists.txt
07a2ef2
@MelamudMichael
Update CMakeLists.txt
0a717e5
@MelamudMichael
Update CMakeLists.txt
fae945c
@MelamudMichael
Update CMakeLists.txt
bcd6493
@MelamudMichael
Update CMakeLists.txt
d8ef779
@MelamudMichael
Update CMakeLists.txt
07ead14
@MelamudMichael
Update conanfile.py
37ec538
@MelamudMichael
Update conanfile.py
1de9db4
@MelamudMichael
adding unittests stub
e80537e
@MelamudMichael
Update conanfile.py
dc4de9d
gregmedd
gregmedd reviewed Mar 12, 2024
View reviewed changes
conaninfo/conanfile.txt Outdated Show resolved Hide resolved
gregmedd
gregmedd approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@gregmedd gregmedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested build instructions in README.md with this change and it worked. LGTM

stevenhartley
stevenhartley requested changes Mar 13, 2024
View reviewed changes
Copy link

@stevenhartley stevenhartley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. Also how can I build/run the tests? We need to add them to the workflow as well.

test/CMakeLists.txt Outdated Show resolved Hide resolved
test/CMakeLists.txt Outdated Show resolved Hide resolved
test/src/main_test.cpp Outdated Show resolved Hide resolved
test/src/main_test.cpp Outdated Show resolved Hide resolved
@MelamudMichael
Copy link
Contributor Author

See comments. Also how can I build/run the tests? We need to add them to the workflow as well.

we dont have tests yet...i will add instructions once we will have tests

@MelamudMichael
Copy link
Contributor Author

we dont have tests yet...i will add instructions once we will have tests

we dont have tests yet...i will add instructions once we will have tests

@stevenhartley stevenhartley merged commit a4dada1 into eclipse-uprotocol:main Mar 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billpittman billpittman billpittman approved these changes

@stevenhartley stevenhartley stevenhartley approved these changes

@gregmedd gregmedd gregmedd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MelamudMichael @billpittman @stevenhartley @gregmedd