Updated Uri Validator in Test Agents, and added higher coverage and cleaner Gherkin Uri Validator tests #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gherkin tests, and created helper function to help cast data (Caster)
test_agent/java/src/main/java/org/eclipse/uprotocol/Caster.java
Outdated
Show resolved
Hide resolved
test_agent/java/src/main/java/org/eclipse/uprotocol/Caster.java
Outdated
Show resolved
Hide resolved
princemac
suggested changes
May 29, 2024
neelam-kushwah
approved these changes
May 30, 2024
There was a problem hiding this comment.
Changes looks good to me.
@matthewd0123, going forward, please ensure that everyone uses the same Python formatter. You can export your formatter settings and provide it to the team to avoid any further formatting-related issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Uri Validator in Python and Java Test Agents
Added higher coverage and cleaner Gherkin Uri Validator tests