Uprotocol 1.5 #61
Closed
Uprotocol 1.5 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated original Co-authored-by: Giorgio Zoppi <giorgio.zoppi@gmail.com>
stevenhartley
requested changes
Mar 5, 2024
There was a problem hiding this comment.
What we need is uProtocol based uAttributes builder meaning we build publish, notification, request, and response headers, otherwise you leave the complexity of building these types (and ensuring the right information is populated) up to the app developer who will more often than not miss something that is mandatory.
There was a problem hiding this comment.
why are there 2 attribute builders?
the date is wrong in the file, need to be 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is adding support for uattributes from proto , and adds a new uattributes builder class