-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating a uAttributes Builder Class #40
Closed
moniercoding
wants to merge
23
commits into
eclipse-uprotocol:uprotocol-1.5
from
moniercoding:uprotocol-1.5
Closed
Creating a uAttributes Builder Class #40
moniercoding
wants to merge
23
commits into
eclipse-uprotocol:uprotocol-1.5
from
moniercoding:uprotocol-1.5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated original
…-credit-patch-1 Update CONTRIBUTORS.adoc
Let's get started.
Updated original Co-authored-by: Giorgio Zoppi <giorgio.zoppi@gmail.com>
* First Draft many compile Errors just backup * aligning * update all tests * Minor Fixes to tests and builders * add id support to micro serialiazer * change from Cgreen to Google test * add function to enhance readability and remove remarked code * Update CMakeLists.txt * Update CMakeLists.txt * Improve readability of long serializer * change to inline getFirstNotEmpty * remove wrong uprotocol-core-api * add the support for the new UAuthority proto * update readme.md * compilation fix * aligning * Update BuildEntity.h * Update BuildUAuthority.h * Update BuildUResource.h * Update BuildUUri.h * Fix dates and Documentations * Add function to add ip or id in microserializer * Update CMakeLists.txt --------- Co-authored-by: Adi Enzel (Adi Enzel) <adi.enzel@gm.com> Co-authored-by: Adi Enzel (Adi Enzel) <adienzel@gmail.com> Co-authored-by: Michael <4115205+xz62px@users.noreply.github.com> Co-authored-by: Michael Melamud <michael.melamud@gm.com>
* First Draft many compile Errors just backup * aligning * update all tests * Minor Fixes to tests and builders * add id support to micro serialiazer * change from Cgreen to Google test * add function to enhance readability and remove remarked code * Update CMakeLists.txt * Update CMakeLists.txt * Improve readability of long serializer * change to inline getFirstNotEmpty * remove wrong uprotocol-core-api * add the support for the new UAuthority proto * update readme.md * compilation fix * aligning * Update BuildEntity.h * Update BuildUAuthority.h * Update BuildUResource.h * Update BuildUUri.h * Fix dates and Documentations * Add function to add ip or id in microserializer * Update CMakeLists.txt * deleting all * pushing everything * cleanup * Update README.md * Update README.md --------- Co-authored-by: Adi Enzel (Adi Enzel) <adi.enzel@gm.com> Co-authored-by: Adi Enzel (Adi Enzel) <adienzel@gmail.com> Co-authored-by: Michael <4115205+xz62px@users.noreply.github.com> Co-authored-by: Michael Melamud <michael.melamud@gm.com>
* Keep unit tests as optional Signed-off-by: Uilian Ries <uilianries@gmail.com> * add project testing option Signed-off-by: Uilian Ries <uilianries@gmail.com> --------- Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
* cleanup * aliging to conan 2.0 * aliging to conan * reverting * Update CMakeLists.txt * Update CMakeLists.txt * Update CMakeLists.txt * Update CMakeLists.txt * Update CMakeLists.txt * Update IpAddress.cpp * Update UuidSerializer.cpp * Update CMakeLists.txt * Update CMakeLists.txt * Update CMakeLists.txt * Update CMakeLists.txt * Update CMakeLists.txt * Update CMakeLists.txt * updating * Update README.md --------- Co-authored-by: Michael Melamud <michael.melamud@gm.com>
MelamudMichael
suggested changes
Feb 18, 2024
…ges (eclipse-uprotocol#54) * up level cmakelists added + code-workspace file * bugfix - then linking with up-cpp static library we have multiple definition * cmakes rewriting - Modern Cmake support * FIXED: conanbuildinfo.cmake invoked in build; was deleted by mistake previously; FIXED: target output directory; added `ctest' support from build directory * added namespace to artifacts to avoid conlisions in the future * bug fixed in debug should use another varibale * protobuf/3.21.12 + spdlog/1.13.0 + gtest/1.14.0 * rm find_package(fmt REQUIRED) as it dependency of spdlog and used explicitly * removed cmake_find_package and pkg_config generators - deprecated in conan 2.x version. * FIXED: CMakeToolchain generator is being declared in both the generators attribute and the generate() method. * Update UPayload.h * Update upayload_test.cpp * note to remove *.up file * readme --------- Co-authored-by: Michael <4115205+MelamudMichael@users.noreply.github.com>
MelamudMichael
suggested changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is OK , but it should not be merged before the up-client PR is ready
did you run the unit-tests?
* Added up-core-api submodule at tag uprotocol-core-api-1.5.6 * support up-core-api submodule * create a library to hold the generated proto files * Switched up-core-api submodule to uprotocol-core-api-1.5.5 * make all generated code linked into up-cpp library * fix proto cmake * Switched up-core-api submodule to uprotocol-core-api-1.5.6 * readme updated * rm NA file * fixes for local conan create
* adding thradpool * thread pool testing * fixing code review * Auto stash before merge of "feature/addingThreadPool" and "main_upstream/main" * reverting --------- Co-authored-by: Michael Melamud <michael.melamud@gm.com>
* Adding workflow to build and test * remove cargo stuff that is not needed * more changes to get conan installed * cancel any in progress so that it is more efficient * remove concurrency, not working * only trigger for push on main * Add conan profile support * retrigger CI * fix detect of profile
* Add conan package create to ci workflow * retrigger workflow * don't need zenoh stuff in up-cpp
Why are we not moving to UAttributes to align with core-api 1.5.6? |
Creating a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.