Address spec alignment issue by revising UTransport and NotificationSink APIs #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code coverage report is ready! 📈
|
|
Remaining work:
|
|
Code coverage report is ready! 📈
|
|
Code coverage report is ready! 📈
|
|
Code coverage report is ready! 📈
|
|
Code coverage report is ready! 📈
|
|
Code coverage report is ready! 📈
|
gregmedd
force-pushed
the
bugfix/1.6.0/237-spec-uri-alignment-issue
branch
from
476493c
to
6fffc22
Compare
|
Code coverage report is ready! 📈
|
gregmedd
commented
Jul 18, 2024
billpittman
reviewed
Jul 22, 2024
billpittman
reviewed
Jul 22, 2024
gregmedd
commented
Jul 22, 2024
gregmedd
force-pushed
the
bugfix/1.6.0/237-spec-uri-alignment-issue
branch
from
6fffc22
to
6218281
Compare
|
Code coverage report is ready! 📈
|
The UTransport API was not well aligned with the final version of the UProtocol 1.6.0 spec, in particular around the optionality of URI filters for registered listeners. This change adds new methods that better align with the intent of the spec. The existing APIs are retained (in some cases with new workarounds for buggy behavior) having now been flagged as deprecated.
UTransport now calls it the "entity" or "default entity" URI to avoid confusion since it is not solely used as a source address (it could also be used in constructing a sink filter). Deprecating isValid() check. Either a specific message type validity check should be used (in the case of a message with attributes) or the isValidFilter() should be used.
gregmedd
force-pushed
the
bugfix/1.6.0/237-spec-uri-alignment-issue
branch
from
6218281
to
9783123
Compare
|
Code coverage report is ready! 📈
|
With the source/sink pivot in UTransport, some adjustment in Layer 2 was necessar. This includes removing calls to deprecated APIs and adjusting the NotificationSink API to match the UTransport changes.
Many tests broke when changes were made to validate source URIs with a situation-specific validator instead of the generic isValid() check.
This test validates the transport mock, but has no assertions on the behavior of the base UTransport class. It qualifies as an "extra" test - it does not contribute coverage to the up-cpp library.
gregmedd
force-pushed
the
bugfix/1.6.0/237-spec-uri-alignment-issue
branch
from
9783123
to
d5cc19e
Compare
|
Code coverage report is ready! 📈
|
|
@stevenhartley @billpittman - Changes have been made to this PR. Please confirm your comments have been addressed and approve. Thanks! |
This was referenced Jul 25, 2024
billpittman
approved these changes
Jul 25, 2024
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core changes here:
UTransportAPI to correct alignment on optional/required URIs when registering listenersNotificationSinkAPI to align withUTransportAPI updatevalidator::uri::isValidFilter())validator::uri::isValid()in the process)SubscriberandNotificationSinkEach change above, plus all of the unit test updates, ripple outward from the correction to the source and sink URIs in
UTransport,NotificationSink, andSubscriber.