diff --git a/rest/resource-server/src/main/java/org/eclipse/sw360/rest/resourceserver/core/RestControllerHelper.java b/rest/resource-server/src/main/java/org/eclipse/sw360/rest/resourceserver/core/RestControllerHelper.java index 1fbb3c9809..034274f05b 100644 --- a/rest/resource-server/src/main/java/org/eclipse/sw360/rest/resourceserver/core/RestControllerHelper.java +++ b/rest/resource-server/src/main/java/org/eclipse/sw360/rest/resourceserver/core/RestControllerHelper.java @@ -610,6 +610,18 @@ public User convertToEmbeddedUser(User user) { return embeddedUser; } + public User convertToEmbeddedGetUsers(User user) { + User embeddedUser = new User(); + embeddedUser.setId(user.getId()); + embeddedUser.setFullname(user.getFullname()); + embeddedUser.setEmail(user.getEmail()); + embeddedUser.setGivenname(user.getGivenname()); + embeddedUser.setLastname(user.getLastname()); + embeddedUser.setDepartment(user.getDepartment()); + embeddedUser.setType(null); + return embeddedUser; + } + public void addEmbeddedObligations(HalResource halLicense, List obligations) { for (Obligation obligation : obligations) { HalResource obligationHalResource = addEmbeddedObligation(obligation); diff --git a/rest/resource-server/src/main/java/org/eclipse/sw360/rest/resourceserver/user/UserController.java b/rest/resource-server/src/main/java/org/eclipse/sw360/rest/resourceserver/user/UserController.java index db915ac1bb..67506307f0 100644 --- a/rest/resource-server/src/main/java/org/eclipse/sw360/rest/resourceserver/user/UserController.java +++ b/rest/resource-server/src/main/java/org/eclipse/sw360/rest/resourceserver/user/UserController.java @@ -68,7 +68,7 @@ public ResponseEntity>> getUsers() { List> userResources = new ArrayList<>(); for (User sw360User : sw360Users) { - User embeddedUser = restControllerHelper.convertToEmbeddedUser(sw360User); + User embeddedUser = restControllerHelper.convertToEmbeddedGetUsers(sw360User); EntityModel userResource = EntityModel.of(embeddedUser); userResources.add(userResource); } diff --git a/rest/resource-server/src/test/java/org/eclipse/sw360/rest/resourceserver/restdocs/UserSpecTest.java b/rest/resource-server/src/test/java/org/eclipse/sw360/rest/resourceserver/restdocs/UserSpecTest.java index 31095d9cbf..532106084e 100644 --- a/rest/resource-server/src/test/java/org/eclipse/sw360/rest/resourceserver/restdocs/UserSpecTest.java +++ b/rest/resource-server/src/test/java/org/eclipse/sw360/rest/resourceserver/restdocs/UserSpecTest.java @@ -117,6 +117,11 @@ public void should_document_get_users() throws Exception { ), responseFields( subsectionWithPath("_embedded.sw360:users[]email").description("The user's email"), + subsectionWithPath("_embedded.sw360:users[]department").description("The user's department"), + subsectionWithPath("_embedded.sw360:users[]deactivated").description("The user's deactivated"), + subsectionWithPath("_embedded.sw360:users[]fullName").description("The user's full name"), + subsectionWithPath("_embedded.sw360:users[]givenName").description("The user's given name"), + subsectionWithPath("_embedded.sw360:users[]lastName").description("The user's last name"), subsectionWithPath("_embedded.sw360:users").description("An array of <>"), subsectionWithPath("_links").description("<> to other resources") )));