Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Arc for room broadcast channels #1199

Closed
dyc3 opened this issue Jan 3, 2024 · 2 comments
Closed

Use Arc for room broadcast channels #1199

dyc3 opened this issue Jan 3, 2024 · 2 comments
Assignees
@Victor-M-Giraldo
Labels
balancer Improvements or additions to the load balancer
Milestone
Load Balancing

Comments

@dyc3
Copy link
Owner

dyc3 commented Jan 3, 2024 •
edited
Loading

Broadcasting to all clients in a room requires each receiver to clone() a new copy of the message, causing unnecessary memory allocations. Wrapping the messages in an Arc should allow us to minimize the amount of memory being cloned.
@dyc3 dyc3 added the balancer Improvements or additions to the load balancer label Jan 3, 2024
@dyc3 dyc3 added this to the Load Balancing milestone Jan 3, 2024
@Victor-M-Giraldo
Copy link
Contributor

I would like to work on this.

@Victor-M-Giraldo Victor-M-Giraldo mentioned this issue Jan 11, 2024
Closed
@dyc3
Copy link
Owner Author

dyc3 commented Jan 12, 2024

Closing this because it's not feasible right now, as discussed in #1216

@dyc3 dyc3 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Victor-M-Giraldo Victor-M-Giraldo

Labels
balancer Improvements or additions to the load balancer
Projects
OTT Horizontal Scaling
Archived in project
Milestone
Load Balancing
Development

Successfully merging a pull request may close this issue.

use arc for broadcast channels Victor-M-Giraldo/opentogethertube
2 participants
@dyc3 @Victor-M-Giraldo