Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the Stat Analysis Additional Filename Template Tags #2639

Open
24 tasks
CPKalb opened this issue Jul 16, 2024 · 0 comments
Open
24 tasks

Enhance the Stat Analysis Additional Filename Template Tags #2639

CPKalb opened this issue Jul 16, 2024 · 0 comments
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle type: enhancement Improve something that it is currently doing

Comments

@CPKalb
Copy link
Contributor

CPKalb commented Jul 16, 2024

Describe the Enhancement

The lead time templates in Stat Analysis do not allow formatting. So, {lead?fmt=%3H} in Stat-Analysis always produces the lead time in HHMMSS (like 030000); the time templates have no effect. The specific tags this applies to are listed below. We should allow formatting for lead time in the Stat-Analysis special templates. Allowing formatting will also mean that we have some redundant tags. I don't know if these are used for another purpose in the wrapper or in use cases, or if they could be removed.

Tags that should allow formatting and currently don't support it:
lead
fcst_lead
obs_lead

Tags that don't allow formatting but will become redundant once formatting is supported in the above tags:
lead_hour
lead_min
lead_sec
lead_totalsec
fcst_lead_hour
fcst_lead_min
fcst_lead_sec
fcst_lead_totalsec
obs_lead_hour
obs_lead_min
obs_lead_sec
obs_lead_totalsec

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as a METplus-Wrappers-X.Y.Z version, Consider for Next Release, or Backlog of Development Ideas
  • For a METplus-Wrappers-X.Y.Z version, select the METplus-Wrappers-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: METplus-Wrappers-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@CPKalb CPKalb added type: enhancement Improve something that it is currently doing alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle and removed alert: NEED MORE DEFINITION Not yet actionable, additional definition required labels Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle type: enhancement Improve something that it is currently doing
Projects
None yet
Development

No branches or pull requests

2 participants