Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing fix for SelfHandling? #254

Open
sambenskin opened this issue Sep 25, 2024 · 1 comment · May be fixed by #261
Open

Missing fix for SelfHandling? #254

sambenskin opened this issue Sep 25, 2024 · 1 comment · May be fixed by #261

Comments

@sambenskin
Copy link

sambenskin commented Sep 25, 2024 •
edited
Loading

The SelfHandling interface was deprecated in Laravel 5.2 and removed in 5.3, but when I run either LaravelSetList::LARAVEL_52 or LaravelSetList::LARAVEL_53 It's not affecting any of the files where we have code like

class SomeJob extends Job implements SelfHandling

My understanding is that this just needs removing so it should correct this line to

class SomeJob extends Job

Or have I missed something?
@GeniJaho
Copy link
Collaborator

@sambenskin can you find a link to a PR/commit in the framework where it was removed please?
If we add a rule for it, we would have to add the link in the a comment.
Also, before you implement a custom rule for it, there might be an existing configurable rule to remove an interface, in the base Rector repository 😃

@GeniJaho GeniJaho linked a pull request Oct 17, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add migration rules for Laravel 5.3 driftingly/rector-laravel
2 participants
@sambenskin @GeniJaho