Skip to content

Commit

Permalink
fix(iscsi): remove unneeded iscsi NOP-disable code
Browse files Browse the repository at this point in the history
Commit 7374943 ("fix(iscsi): add support for the new iscsiadm
"no-wait" (-W) command") added some code to try to disable iscsi's
NOPs, since they are considered "bad" for an iscsi root disc,
but that code doesn't work because the session is already established
at this point. Open-iscsi will change so that it automatically
disables NOPs for the root disc, so this code can just go away.
  • Loading branch information
gonzoleeman authored and johannbg committed Feb 26, 2022
1 parent d3ab206 commit a33a8df
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions modules.d/95iscsi/iscsiroot.sh
Original file line number Diff line number Diff line change
Expand Up @@ -82,15 +82,6 @@ handle_firmware() {
if [ $_res -ne 0 ]; then
warn "iscsiadm: Log-in to iscsi target failed"
else
# get a list of connected targets
tgts=$(cat /sys/firmware/ibft/target*/target-name | sort -u)
# disable NOPs for each FW target
for tgt in ${tgts}; do
iscsiadm -m node -T "${tgt}" \
--op update \
--name 'node.conn[0].timeo.noop_out_interval' --value 0 \
--name 'node.conn[0].timeo.noop_out_timeout' --value 0
done
need_shutdown
fi
fi
Expand Down

0 comments on commit a33a8df

Please sign in to comment.