From d3dca19464d24375c8dfa0216d7cb34aa126fe60 Mon Sep 17 00:00:00 2001 From: Maryam Ariyan Date: Thu, 3 Nov 2022 13:12:22 -0700 Subject: [PATCH] Links to issue with more info on flaky behavior - file watcher on non windows has large impact on start time Closes #33992 --- .../tests/FunctionalTests/ConfigurationTests.cs | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ConfigurationTests.cs b/src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ConfigurationTests.cs index aa91bc9d7b3d9..ced9dd64c3007 100644 --- a/src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ConfigurationTests.cs +++ b/src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ConfigurationTests.cs @@ -465,7 +465,7 @@ public void OnLoadErrorCanIgnoreErrors() } [Fact] - [ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/33992")] + [ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/42036")] public void CanSetValuesAndReloadValues() { WriteTestFiles(); @@ -508,7 +508,7 @@ public void CanSetValuesAndReloadValues() } [Fact] - [ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/33992")] + [ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/42036")] public async Task ReloadOnChangeWorksAfterError() { _fileSystem.WriteFile("reload.json", @"{""JsonKey1"": ""JsonValue1""}"); @@ -539,7 +539,7 @@ await WaitForChange( } [Fact] - [ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/33992")] + [ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/42036")] public async Task TouchingFileWillReload() { _fileSystem.WriteFile("reload.json", @"{""JsonKey1"": ""JsonValue1""}"); @@ -576,7 +576,7 @@ await WaitForChange( } [Fact] - [ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/33992")] + [ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/42036")] public async Task CreatingOptionalFileInNonExistentDirectoryWillReload() { var directory = Path.GetRandomFileName(); @@ -610,7 +610,7 @@ await WaitForChange( } [Theory] - [ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/33992")] + [ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/42036")] [InlineData(false)] [InlineData(true)] public async Task DeletingFilesThatRedefineKeysWithReload(bool optional) @@ -691,7 +691,7 @@ await WaitForChange( } [Theory] - [ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/33992")] + [ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/42036")] [InlineData(false)] [InlineData(true)] public async Task DeletingFileWillReload(bool optional) @@ -730,7 +730,7 @@ await WaitForChange( } [Fact] - [ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/33992")] + [ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/42036")] public async Task CreatingWritingDeletingCreatingFileWillReload() { var config = CreateBuilder() @@ -910,7 +910,7 @@ public void CanEnumerateProviders() } [Fact] - [ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/33992")] + [ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/42036")] public async Task TouchingFileWillReloadForUserSecrets() { string userSecretsId = "Test";